Skip to content

Conversation

MiSikora
Copy link
Contributor

@MiSikora MiSikora commented Nov 5, 2024

Description

This PR adds fallback to non-PC requests when hosts refuse to serve content.

Closes #3164

Testing Instructions

  1. Go to Questions & Answers podcast.
  2. Episodes should play and download.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@MiSikora MiSikora added [Type] Enhancement Improve an existing feature. [Area] Downloads [Area] Network Things related to the web connection or communiaction labels Nov 5, 2024
@MiSikora MiSikora added this to the 7.77 milestone Nov 5, 2024
@MiSikora MiSikora requested a review from a team as a code owner November 5, 2024 15:40
@MiSikora MiSikora requested review from ashiagr and removed request for a team November 5, 2024 15:40
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 5, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit2f79946
Direct Downloadpocketcasts-app-prototype-build-pr3180-2f79946.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit2f79946
Direct Downloadpocketcasts-automotive-prototype-build-pr3180-2f79946.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit2f79946
Direct Downloadpocketcasts-wear-prototype-build-pr3180-2f79946.apk

@MiSikora MiSikora changed the title Retry streaming and downloading when with different headers Retry streaming and downloading with different headers Nov 5, 2024
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Thanks for fixing it!

@ashiagr ashiagr merged commit 1f0d03e into main Nov 6, 2024
18 of 20 checks passed
@ashiagr ashiagr deleted the task/agent-interceptor branch November 6, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Downloads [Area] Network Things related to the web connection or communiaction [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to play Episode
3 participants