types(schematype): make defaultOptions static and add schemaOptions to DocumentArray #15529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates how defaultOptions is exposed on schema types—making it a static property on SchemaType and all Schema.Types.* classes—and introduces schemaOptions to DocumentArray.
- Move
defaultOptionsfrom instance members to static properties onSchemaTypeand its subclasses. - Adjust tests in
schemaTypeOptions.test.tsto validate static access ofdefaultOptions. - (Not shown here) Add
schemaOptionsto theDocumentArraytype definition.
Comments suppressed due to low confidence (1)
test/types/schemaTypeOptions.test.ts:77
- Add a test for the new static
schemaOptionsproperty onDocumentArrayto ensure its type is correctly inferred, e.g.:expectType<Record<string, any> | undefined>(Schema.Types.DocumentArray.schemaOptions);
}
hasezoey
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some followup work for #15524:
defaultOptionsis actually a static property on SchemaTypes, not an instance property. Also, addschemaOptions.Examples