Bugfix: Model.validate() hangs when all paths fail casting
#15580
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug where Model.validate() would hang indefinitely when all specified validation paths fail type casting. The issue occurred because the validation loop would become empty after casting failures, but the Promise would never be resolved or rejected.
- Refactored Promise handling logic to detect when no validation paths remain
- Added early settlement check to prevent hanging when all paths are removed
- Extracted settlement logic into a reusable helper function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/model.js | Fixed Promise hanging issue by adding early settlement check and extracting settlement logic |
| test/model.validate.test.js | Added test case to verify the fix handles casting failures correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Model.validate()hangs indefinitely when all specified validation paths fail type casting. The Promise never resolves or rejects, causing timeouts.Root cause
castObject()throws a ValidationError and removes failed paths from the validation queueremaining = 0)_checkDone()is never called because the loop doesn't executeSolution
Refactored the Promise handling logic to properly handle the case when all validation paths are removed due to casting errors. The key changes:
Early settlement check: Added
if (remaining === 0) { return settle(); }immediately after creating the Promise to handle the case where no paths need validationExtracted settlement logic: Created a
settle()helper function to centralize Promise resolution/rejection logic