fix(model): allow setting statics option on discriminator schema
#15568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue (#15556) where discriminator schemas were not allowed to set the statics option, despite being able to set methods and virtuals options. The change enables discriminator schemas to customize their static methods by adding statics to the list of customizable discriminator options.
- Added
staticsto theCUSTOMIZABLE_DISCRIMINATOR_OPTIONSobject - Updated the error message to include
staticsin the list of allowed customizable options
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/helpers/model/discriminator.js | Added statics: true to the CUSTOMIZABLE_DISCRIMINATOR_OPTIONS object |
| test/model.discriminator.test.js | Updated error message test to include statics in the list of allowed options |
hasezoey
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15556
Summary
We allow discriminator schemas to set
methodsandvirtualsoptions with #12246, I thinkstaticsshould also be allowed.Examples