fix(model): remove unnecessary conversion of undefined -> null in findById #15566
+1
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary undefined handling in the findById() method and updates its documentation to reflect current behavior. The change eliminates a conversion that was previously needed when findOne({ _id: undefined }) returned arbitrary documents, which is no longer the case.
- Remove conditional check that converts
undefinedtonullinfindById() - Update documentation to reflect that
findById(id)is now equivalent tofindOne({ _id: id }) - Remove outdated documentation explaining the difference in undefined handling between the two methods
hasezoey
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15551
Summary
The
findById()documentation indicates thatfindOne({ _id: undefined })will return an arbitrary document, which is no longer accurate. I also removed theundefinedcheck infindById(), which is no longer necessary becausefindOne({ _id: undefined })no longer returns an arbitrary document.Examples