Skip to content

types(connection): add base to connection type #15544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

types(connection): add base to connection type #15544

merged 1 commit into from
Jul 22, 2025
+4 −0

Conversation

vkarpov15
Copy link
Collaborator

Summary

Quick little issue I noticed - connections have a base property at runtime that points back to the Mongoose instance, but TypeScript types don't have that

Examples

@vkarpov15 vkarpov15 added this to the 8.16.5 milestone Jul 21, 2025
Copilot
Copilot AI reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Jul 22, 2025
@vkarpov15 vkarpov15 merged commit 6be3ae0 into master Jul 22, 2025
5 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/base-type branch July 22, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
8.16.5
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarpov15 @hasezoey