make Schema.prototype.$conditionalHandlers public #15497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR makes the internal $conditionalHandlers property public on various schema types by exposing it via Object.defineProperty with appropriate documentation. Key changes include updating lib/schemaType.js to add a public API description and applying the same change consistently across multiple schema-specific files.
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/schemaType.js | Added a doc comment and exposed $conditionalHandlers publicly |
| lib/schema/uuid.js | Added the public API documentation for $conditionalHandlers |
| lib/schema/subdocument.js | Replaced internal $conditionalHandlers use with a defined public version |
| lib/schema/string.js | Added public documentation and exposed $conditionalHandlers |
| lib/schema/objectId.js | Added public documentation for the $conditionalHandlers property |
| lib/schema/number.js | Exposed $conditionalHandlers publicly with an API comment |
| lib/schema/int32.js | Added public API documentation and exposure for $conditionalHandlers |
| lib/schema/double.js | Exposed $conditionalHandlers publicly with documentation |
| lib/schema/documentArray.js | Updated to expose $conditionalHandlers publicly with a descriptive comment |
| lib/schema/decimal128.js | Added public documentation and exposure for $conditionalHandlers |
| lib/schema/date.js | Exposed $conditionalHandlers publicly with an API doc comment |
| lib/schema/buffer.js | Added public documentation and exposure for $conditionalHandlers |
| lib/schema/boolean.js | Exposed $conditionalHandlers publicly with a descriptive comment |
| lib/schema/bigint.js | Added public API documentation and exposure for $conditionalHandlers |
| lib/schema/array.js | Exposed $conditionalHandlers publicly with accompanying documentation |
hasezoey
approved these changes
Jun 30, 2025
AbdelrahmanHafez
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
$conditionalHandlerspublic to allow adding custom conditional handlersExamples