Fix table view delegate message forwarding #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've encountered an issue with message forwarding on my iPad (Mini 2 iOS 8.1.3 FWIW). UITableViewDelegate methods were not called. The root cause is that UITableView caches the results of respondsToSelector calls for all delegate methods and does it at the very moment when a new delegate is set. Thus, it happened when the delegate was set from commonInit, and at that moment self.tableViewDelegate was still nil. Later on, since the delegate was set to the same instance (self) in setTableViewDelegate, UITableView skipped updating that cache and was assuming all methods to be still not implemented, no calls were made, and the table was not interactable. Resetting the delegate on UITableView first before setting it forced it to refresh the cache and calls were then received as expected.
|
Thanks for contribution! |
Augustyniak
added a commit
that referenced
this pull request
Nov 28, 2015
Fix table view delegate message forwarding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered an issue with message forwarding on my iPad (Mini 2 iOS 8.1.3 FWIW). UITableViewDelegate methods were not called.
The root cause is that UITableView caches the results of respondsToSelector calls for all delegate methods and does it at the very moment when a new delegate is set. Thus, it happened when the delegate was set from commonInit, and at that moment self.tableViewDelegate was still nil. Later on, since the delegate was set to the same instance (self) in setTableViewDelegate, UITableView skipped updating that cache and was assuming all methods to be still not implemented, no calls were made, and the table was not interactable.
Resetting the delegate on UITableView first before setting it forced it to refresh the cache and calls were then received as expected.