Implement audio layers #1149
Merged
Implement audio layers #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…top when the pause button is pressed
Only works with mp3 for now
At least until I find a way to save them. Wav files will be supported with Godot 4.4
…layer is selected
…ck menu of cel buttons
…frame so maybe we should do that as well When the animation is not running. If it is running, play the sound properly.
…r audio This woud allow audio to be placed in negative frames, which essentially means that audio would start before the first frame. This is not yet supported, however, because I don't know how to make it work with FFMPEG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #897. Each audio layer has a sound effect which can be played at a certain frame. They're not visual, but I figured it would be best if they were somehow visible in the timeline, as they can be used to help artists sync their animations with audio. Audio also gets imported/exported with videos, if FFMPEG is installed. At the moment, only mp3 files are supported, with wav files support coming with Godot 4.4. While ogg file loading is possible, I couldn't figure out a way to save them. If we do, we could also support ogg files.
2024-12-10.15-11-10.mp4
The musical note textures on audio cels represent the frames where the audio plays, and empty cels means that the audio does not play there, either because they are before it starts playing, or it has finished playing. This also depends on the animation's FPS, and the individual frame delay. Not too happy about how it looks though. Perhaps ideally we should have some kind of audio spectrum visualizer, like in most audio & video editing software, but I'm not too sure how to do that yet, or if it's worth the effort, or if it will have some kind of impact on performance.
Since this PR changes the audio driver to no longer be Dummy in order for the audio to be heard, I also added a new option in the Preferences, under the Performance category, that allows users to set the audio driver to Dummy if they experience performance issues.