Fix NRE when the user set their time zone as the site's (Lombiq Technologies: OCORE-200) #16777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pted to use the site's
|
@emrahtokalak could you check, please? |
Piedone
commented
Sep 21, 2024
src/OrchardCore.Modules/OrchardCore.Users/TimeZone/Services/UserTimeZoneService.cs
Outdated
Show resolved
Hide resolved
MikeAlhayek
reviewed
Sep 23, 2024
src/OrchardCore.Modules/OrchardCore.Users/TimeZone/Services/UserTimeZoneService.cs
Outdated
Show resolved
Hide resolved
gvkries
approved these changes
Sep 24, 2024
MikeAlhayek
reviewed
Sep 24, 2024
src/OrchardCore.Modules/OrchardCore.Users/TimeZone/Services/UserTimeZoneSelector.cs
Show resolved
Hide resolved
MikeAlhayek
approved these changes
Sep 24, 2024
MikeAlhayek
reviewed
Sep 24, 2024
| : new TimeZoneSelectorResult | ||
| { | ||
| Priority = 100, | ||
| TimeZoneId = async () => (await _userTimeZoneService.GetAsync(currentUser))?.TimeZoneId |
There was a problem hiding this comment.
@Piedone I don't think there is a need for the async here. just return a task would be better
|
/backport to release/2.0 |
|
Started backporting to release/2.0: https://github.com/OrchardCMS/OrchardCore/actions/runs/11022226865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16776.