Skip to content

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Dec 28, 2023

remove ALL dead code

@JarbasAl JarbasAl requested a review from a team December 28, 2023 16:30
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (92f80e1) 31.92% compared to head (ab6ce75) 31.03%.
Report is 5 commits behind head on dev.

Files Patch % Lines
ovos_utils/sound.py 17.39% 57 Missing ⚠️
ovos_utils/skills.py 0.00% 14 Missing ⚠️
ovos_utils/version.py 0.00% 3 Missing ⚠️
ovos_utils/signal.py 0.00% 2 Missing ⚠️
ovos_utils/process_utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #204      +/-   ##
==========================================
- Coverage   31.92%   31.03%   -0.89%     
==========================================
  Files          49       51       +2     
  Lines        6524     5770     -754     
==========================================
- Hits         2083     1791     -292     
+ Misses       4441     3979     -462     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl marked this pull request as draft December 28, 2023 16:37
@JarbasAl JarbasAl changed the title Delete ovos_utils/ovos_service_api.py rm non-functional backwards compat code Dec 28, 2023
@JarbasAl JarbasAl added bug Something isn't working breaking breaks backwards compatibility refactor code improvements with no functional changes labels Dec 28, 2023
@JarbasAl
Copy link
Member Author

increasing the scope of this PR, removing all deprecated code and preparing for 0.1.0 release!

@JarbasAl JarbasAl changed the title rm non-functional backwards compat code 0.1.0 alpha 1 Dec 28, 2023
JarbasAl added a commit to OpenVoiceOS/ovos-bus-client that referenced this pull request Dec 28, 2023
JarbasAl added a commit to OpenVoiceOS/ovos-bus-client that referenced this pull request Dec 28, 2023
JarbasAl added a commit to OpenVoiceOS/ovos-bus-client that referenced this pull request Dec 28, 2023
@JarbasAl JarbasAl force-pushed the Delete-ovos_utils/ovos_service_api.py branch from 746169a to 43c3fe0 Compare December 28, 2023 21:06
@JarbasAl JarbasAl marked this pull request as ready for review December 28, 2023 21:12
@JarbasAl JarbasAl force-pushed the Delete-ovos_utils/ovos_service_api.py branch from 1e8bc20 to ca0575b Compare December 28, 2023 23:35
@JarbasAl JarbasAl force-pushed the Delete-ovos_utils/ovos_service_api.py branch from 678ca68 to b7ea346 Compare December 28, 2023 23:41
@JarbasAl JarbasAl merged commit d181769 into dev Dec 29, 2023
@JarbasAl JarbasAl deleted the Delete-ovos_utils/ovos_service_api.py branch December 29, 2023 00:38
@JarbasAl JarbasAl mentioned this pull request Dec 29, 2023
14 tasks
JarbasAl added a commit that referenced this pull request Dec 29, 2023
rebase 0.0.38
JarbasAl added a commit that referenced this pull request Dec 29, 2023
rebase 0.0.38
emphasize pushed a commit to emphasize/ovos-utils that referenced this pull request Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaks backwards compatibility bug Something isn't working refactor code improvements with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant