Skip to content

Conversation

LeeSpork
Copy link
Contributor

@LeeSpork LeeSpork commented Mar 21, 2025

After pausing and then unpausing the game, the background music will now resume playing from where it left off, matching original behaviour.

Closes #3038

@LeeSpork
Copy link
Contributor Author

LeeSpork commented Mar 21, 2025

It can be discussed in future issues whether other audio should also use the channel pausing feature implemented here. (Though if so: may want to check all uses of Channel::isPlaying() to prevent any potential bugs – it perhaps might make sense to just entirely replace that method with a isPlayingOrPaused method?)

@duncanspumpkin
Copy link
Contributor

Could you rebase/merge in master and fix the changelog

@duncanspumpkin duncanspumpkin added this to the v25.03+ milestone Apr 24, 2025
@duncanspumpkin duncanspumpkin enabled auto-merge (squash) April 24, 2025 08:02
@duncanspumpkin duncanspumpkin merged commit 3fbf74d into OpenLoco:master Apr 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Song changes when game paused
2 participants