Skip to content

Implement Company Ai: Choosing destinations / initial thought setup #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 28, 2025
Merged

Implement Company Ai: Choosing destinations / initial thought setup #3013

merged 10 commits into from
Mar 28, 2025

Conversation

duncanspumpkin
Copy link
Contributor

Not tested

AaronVanGeffen
AaronVanGeffen reviewed Mar 27, 2025
View reviewed changes
Copy link
Member

@AaronVanGeffen AaronVanGeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, I'm fine with this, but the OP says it hasn't been tested yet. Could we test this for replays to match at least?

@duncanspumpkin
Copy link
Contributor Author

Code-wise, I'm fine with this, but the OP says it hasn't been tested yet. Could we test this for replays to match at least?

looks to have some issues so not ready yet

LeftofZen
LeftofZen approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@LeftofZen LeftofZen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if I fully playtested all the new code here, but the AI on this branch does indeed form roads and tracks between producer and consumer industries:

image

This AI built from an oil well to a refinery further away than necessary (but maybe this is legit, maybe it wants higher income or something):
image

Bus routes generated:
image

I saw the AI generate docks and a ship, but they deleted it before I could find it (I think this is already existing behaviour)

@duncanspumpkin
Copy link
Contributor Author

I have confirmed that the only issue (replay wise) is due to a bug in vanilla. Do we want to do a divergence in this release (#3043 will also diverge replays) ?

duncanspumpkin added a commit to OpenLoco/TestData that referenced this pull request Mar 28, 2025
@duncanspumpkin
Update test data for OpenLoco/OpenLoco#3013
c787563
@duncanspumpkin
Copy link
Contributor Author

Replays match (after updating the test data confirmed it was a vanilla mistake causing the divergence) OpenLoco/TestData@c787563

@duncanspumpkin duncanspumpkin merged commit 982f33f into OpenLoco:master Mar 28, 2025
19 checks passed
@duncanspumpkin duncanspumpkin deleted the companyAi5 branch March 28, 2025 22:11
@duncanspumpkin duncanspumpkin added this to the v25.02+ milestone Mar 28, 2025
duncanspumpkin added a commit to duncanspumpkin/OpenLoco that referenced this pull request Mar 29, 2025
@duncanspumpkin
Add missing changelog for OpenLoco#3013
5ba8aac
duncanspumpkin added a commit that referenced this pull request Mar 29, 2025
@duncanspumpkin
#3013 Cleanup (#3053)
a2f25b4 
* Add missing changelog for #3013

* Don't pass by ref when value not used again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronVanGeffen AaronVanGeffen AaronVanGeffen left review comments

@LeftofZen LeftofZen LeftofZen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v25.03
Development

Successfully merging this pull request may close these issues.
3 participants
@duncanspumpkin @AaronVanGeffen @LeftofZen