Fallback to attr icon when ons-tab updates button content #2720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Expected behavior When updating the tab attribute, e.g. `badge`, while the tab is active, the icon should fallback to the `icon` attribute if the `active-icon` attribute is not specified. ## Current behavior In `setActive` method, it behaves as expected by implicitly not updating the icon if the `active-icon` attributed is not specified. However, in `_updateButtonContent` it will set icon to null if the `active-icon` is not specified. ## Temporary solution I can currently workaround the issue by explicitly set the `active-icon` attribute to the same value as the `icon` attribute. But the proposed the change would make the behavior consistent.
|
Nice catch! Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
When updating the tab attribute, e.g.
badge, while the tab is active, the icon should fallback to theiconattribute if theactive-iconattribute is not specified.Current behavior
In
setActivemethod, it behaves as expected by implicitly not updating the icon if theactive-iconattributed is not specified. However, in_updateButtonContentit will set icon to null if theactive-iconis not specified.Temporary solution
I can currently workaround the issue by explicitly set the
active-iconattribute to the same value as theiconattribute. But the proposed the change would make the behavior consistent.