Add documentation for METADATA_STATISTICS_UPDATED #5069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
excess empty line removed
|
Thanks for that! Quick hint, the easiest way to solve issues the the pre-commit step finds on the CI is to have it installed on your local check-out as well - it will then complain on the commit itself, and even fix it for you (at least in most of cases) so you can just add the changes to the commit. See the developer docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
develbranch if it's a completelynew feature, or
maintenanceif it's a bug fix or improvement ofexisting functionality for the current stable version (no PRs
against
masteror anything else please)(no PRs from your version of
master,maintenance, ordevelplease), e.g.
dev/my_new_featureorfix/my_bugfixno dead code, ideally only one commit - rebase and squash your PR
if necessary!
AUTHORS.mdfile :)What does this PR do and why is it necessary?
adds missing doc. Stops users from staring at events in plugin code that are not in the list of events in the docs like I did :)
What are the relevant tickets if any?
I did not create one.
Further notes
I added the OctoPrint version in which the event was last changed. I have no idea what variables it might have used previously which are now deprecated so that section is missing. As those were never documented, I think that's ok.