Chamber Offsets not adjusting in G-Code (M141 and M191) #5075
Description
The problem
When printing with Octoprint M104, M140, M109, and M190 will adjust according to the offset in Octoprint, but M141 and M191 are sending the raw value with no adjustment.
I reached out on discord to see if it was a "Me" problem, and they were able to recreate it as well.
some quick snippets
[GCODE FILE (lines 204 - 214)]
;TYPE:Custom
; custom gcode: start_gcode
M140 S110 ; Pull Offset by Math
M104 S240 ; Pull Offset by Math
M141 S50 ; Pull Offset by Math
print_start EXTRUDER=240 BED=110 CHAMBER=50
@BEDLEVELVISUALIZER ; tell the plugin to watch for reported mesh
BED_MESH_OUTPUT
[Serial Log]
2024-10-30 20:08:53,438 - Send: N0 M110 N0125
2024-10-30 20:08:53,441 - Recv: ok
2024-10-30 20:08:53,444 - Send: PRINT_PRESTART
2024-10-30 20:08:53,470 - Recv: ok
2024-10-30 20:08:53,470 - Changing monitoring state from "Starting" to "Printing"
2024-10-30 20:08:53,539 - Send: EXCLUDE_OBJECT_DEFINE NAME=Voron_Design_Cube_v7_stl_id_0_copy_0 CENTER=175.000000,175.000000 POLYGON=[[160.00,160.00],[190.00,160.00],[190.00,190.00],[160.00,190.00],[160.00,160.00]]
2024-10-30 20:08:53,609 - Recv: ok
2024-10-30 20:08:53,617 - Send: N1 M117 0% L=-/150119
2024-10-30 20:08:53,619 - Recv: ok
2024-10-30 20:08:53,621 - Send: N2 M73 P0 R7840
2024-10-30 20:08:53,624 - Recv: ok
2024-10-30 20:08:53,626 - Send: N3 M10738
2024-10-30 20:08:53,638 - Recv: ok
2024-10-30 20:08:53,640 - Send: N4 M140 S116.00000073
2024-10-30 20:08:53,644 - Recv: ok
2024-10-30 20:08:53,647 - Send: N5 M104 S243.00000075
2024-10-30 20:08:53,650 - Recv: ok
2024-10-30 20:08:53,655 - Send: N6 M141 S50*87
2024-10-30 20:08:53,659 - Recv: // Got M141 S = 50.0
2024-10-30 20:08:53,675 - Recv: ok
2024-10-30 20:08:53,686 - Send: print_start EXTRUDER=240 BED=110 CHAMBER=50
2024-10-30 20:08:53,721 - Recv: // Bed Temp = 110.0
2024-10-30 20:08:53,721 - Recv: // Tool Temp = 240.0
2024-10-30 20:08:53,722 - Recv: // Chamber Temp = 50.0
2024-10-30 20:08:53,722 - Recv: // PEI Adjustment = 0
2024-10-30 20:08:53,722 - Recv: // Bed Offset = 6.0
2024-10-30 20:08:53,722 - Recv: // Tool Offset = 3.0
2024-10-30 20:08:53,722 - Recv: // Chamber Offset = 0.0
2024-10-30 20:08:53,722 - Recv: // Filament Type = 0
2024-10-30 20:08:53,722 - Recv: // Last Calibration = 0
2024-10-30 20:08:53,722 - Recv: // Drybox Left Humidity: 34.66%
2024-10-30 20:08:53,722 - Recv: // Drybox Right Humidity: 35.74%
2024-10-30 20:08:53,722 - Recv: info Drybox Right - Disabled
2024-10-30 20:08:53,723 - Recv: info Drybox Left - Disabled
[Klipper Macro snip]
[gcode_macro M141] #No Wait
gcode:
{% set s = params.S|default(0)|float %}
SET_TEMPERATURE_FAN_TARGET temperature_fan="chamber" target={s} min_speed=0.0 max_speed=1.0
SAVE_VARIABLE VARIABLE=chamber_set_temp VALUE={s}
{action_respond_info("Got M141 S = %s" % s)}
[gcode_macro M191] #Wait Case
gcode:
{% set s = params.S|default(0)|float %}
{% set r = params.R|default(0)|float %}
{% if s != 0 %} #Wait for heat
SET_TEMPERATURE_FAN_TARGET temperature_fan="chamber" target={s} min_speed=0.0 max_speed=1.0
SAVE_VARIABLE VARIABLE=chamber_set_temp VALUE={s}
{action_respond_info("Got M191 S = %s" % s)}
{% if printer.extruder.target <= s %}
TEMPERATURE_WAIT SENSOR="temperature_fan chamber" MINIMUM={s} MAXIMUM={s + 40}
{% endif %}
{% endif %}
{% if r != 0 %} #Wait for heat or cooling
SET_TEMPERATURE_FAN_TARGET temperature_fan="chamber" target={r} min_speed=0.0 max_speed=1.0
TEMPERATURE_WAIT SENSOR="temperature_fan chamber" MINIMUM={r} MAXIMUM={r + 5}
SAVE_VARIABLE VARIABLE=Cchamber_set_temp VALUE={r}
{action_respond_info("Got M191 R = %s" % r)}
{% endif %}
Did the issue persist even in safe mode?
Yes, it did persist
If you could not test in safe mode, please state why ("currently printing" is NOT an excuse!)
No response
Version of OctoPrint
1.10.2
Operating system running OctoPrint
Linux version 5.10.0-21-amd64 (debian-kernel@lists.debian.org) (gcc-10 (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2) #1 SMP Debian 5.10.162-1 (2023-01-21)
Printer model & used firmware incl. version
Voron 2.4 R2 - Klipper
Browser and version of browser, operating system running browser
Chrome Version 130.0.6723.70 (Official Build) (64-bit)
Checklist of files to include below
- Systeminfo Bundle (always include!)
- Contents of the JavaScript browser console (always include in cases of issues with the user interface)
- Screenshots and/or videos showing the problem (always include in case of issues with the user interface)
- GCODE file with which to reproduce (always include in case of issues with GCODE analysis or printing behaviour)
Additional information & file uploads
octoprint-systeminfo-20241030212212.zip
plugin_klipper_debug.log
octoprint.log
serial.log
klippy.zip