Skip to content

Wonky Trusted Downstream Validation #5036

@Silvenga

Description

@Silvenga

The problem

When using a reverse proxy within another network, Octoprint appears to incorrectly validate the X-Forwarded-For header.


In my setup, I have the reverse proxy in 172.24.0.0/24. The reverse proxy is proxing for the 192.168.0.0/24 network.

After configuring a static IP on my reverse proxy and configuring that IP in the trusted proxies list of Octoprint, Octoprint incorrectly handles the X-Forwarded-For list.

image

Did the issue persist even in safe mode?

Yes, it did persist

If you could not test in safe mode, please state why ("currently printing" is NOT an excuse!)

No response

Version of OctoPrint

1.10.2

Operating system running OctoPrint

Offical container image, running on Ubuntu 22.04

Printer model & used firmware incl. version

No response

Browser and version of browser, operating system running browser

Firefox 127.0.2 on Windows 11

Checklist of files to include below

  • Systeminfo Bundle (always include!)
  • Contents of the JavaScript browser console (always include in cases of issues with the user interface)
  • Screenshots and/or videos showing the problem (always include in case of issues with the user interface)
  • GCODE file with which to reproduce (always include in case of issues with GCODE analysis or printing behaviour)

Additional information & file uploads

octoprint-systeminfo-20240628132433.zip

Metadata

Metadata

Assignees

Labels

doneDone but not yet releasedimprovementImproving functionality, behaviour, UX, ...

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions