Fix saving with keyboard shortcut so that it actually saves new data #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgadsden
approved these changes
Aug 7, 2025
There was a problem hiding this comment.
very elegant fix, thanks @mitchellwong
I will add to the unit tests in PR #1330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Saving via keyboard shortcut doesn't apply the current diagram to the threatmodel state, so when the model saves, it saves whatever was already in it, which is what's currently on the disk. This is probably the cause of #1254. Saving via the File menu or the Save icon work correctly by applying the diagram to the threatmodel state first, so just replicate that.
Description for the changelog:
Dispatch
THREATMODEL_DIAGRAM_APPLIEDbefore dispatchingTHREATMODEL_SAVEwhen saving via keyboard shortcut.Declaration:
Other info:
Steps to reproduce:
Expected:
Output json file contains expected changes.
Actual:
Output json file is identical to what was already on the disk.
I don't know what unit or functional tests would be added for this since the existing tests clearly didn't catch it and I'm not familiar with this code base enough to confidently write any.