Skip to content

extend DIE to CIA-DIE #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

extend DIE to CIA-DIE #1325

merged 1 commit into from
Jul 17, 2025

Conversation

jgadsden
Copy link
Collaborator

Summary:
Extends DIE to be CIA-DIE, because DIE is not used with the CIA triad
closes #1172 'DIE should be CIA-DIE'

Description for the changelog:
extend DIE to CIA-DIE

Declaration:

  • appropriate unit tests have been created / modified
  • functional tests created / modified for changes in functionality
  • any use of AI has been declared in this pull request

Other info:
I have added extra lines to the CIA-DIE translation files for CIA. These are a direct copy, but allow for the text to diverge in the future

@jgadsden jgadsden self-assigned this Jul 17, 2025
@jgadsden jgadsden requested a review from lreading as a code owner July 17, 2025 15:59
@jgadsden jgadsden added enhancement New feature or request version-2.5 labels Jul 17, 2025
Copy link
Collaborator

@lreading lreading left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jgadsden jgadsden merged commit 0cdf9a0 into main Jul 17, 2025
13 checks passed
@jgadsden jgadsden deleted the cia-die branch July 17, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request version-2.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DIE should be CIA-DIE
2 participants