Skip to content

i18n: Add Japanese translation #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

m10k
Copy link
Contributor

@m10k m10k commented Mar 30, 2024

Summary:
Adds translation file and tests for Japanese, ISO 639-2 code 'jpn', ISO 639-1 code 'ja'.
Japanese sentence structure is different from English, so where a sentence is split over multiple strings, the individual strings do not match, but the sentence as a whole does.

Description for the changelog:
Add Japanese translation

Other info:
Closes #932

Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good to have this translation @m10k
Did you want to apply the change to file td.vue/src/desktop/menu.js as well?

@m10k m10k force-pushed the m10k-japanese-translation branch from ec28cd2 to d42aa36 Compare March 31, 2024 02:39
@m10k
Copy link
Contributor Author

m10k commented Mar 31, 2024

Hey @jgadsden,
Sorry, I completely missed that file. I just added the necessary changes and amended my commit. I hope this approach is okay.

@jgadsden jgadsden self-requested a review April 1, 2024 08:58
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks @m10k and going ahead with merge

@jgadsden jgadsden merged commit 57e3d2e into OWASP:main Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation to Japanese
2 participants