allows to test mongodb uri via env vars #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue#152 data folder es6 migration
Revert "issue#152 data folder es6 migration"
|
@bizob2828 Thanks for the PR. LGTM |
|
Thanks @bizob2828 this PR seems good to me. I will move the target branch to |
|
ok thanks @UlisesGascon. When will 1.5 be released? I'm currently just using the fork in our test harness but would love to restore using this main repo |
|
@bizob2828 not sure yet about the date. There are many issues and PRs on going. I will ping you back when we have an estimation 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the ability to pass in
MONGOLAB_URIandMONGODB_URIas env vars to set the mongo db uri.Fixes #173