Issue#152 login.html #162
Merged
Issue#152 login.html #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
reviewed
Aug 9, 2019
UlisesGascon
requested changes
Aug 9, 2019
|
Thanks for the PR @lucas1004jx! Welcome aboard 🤗 I just added some context in the PR definition ;-) |
|
@lucas1004jx Thanks for the PR and welcome to the project! Please coordinate with @UlisesGascon if you'd like to further assist on ES6+ migration on any other parts of the code. |
ckarande
approved these changes
Aug 9, 2019
UlisesGascon
approved these changes
Aug 11, 2019
|
As #160 was merged already... I will merge this one :-) Thanks @lucas1004jx ! 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR is part of
Migration to es6+#152.As this tasks is huge, we agreed to split it in little chunks so it can be review it faster 👍
PR Changelog