Python: Add numpy as extras_require dependency (fixes #2158) #2281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing `pip install gdal[numpy]` will install `gdal` with `numpy > 1.0.0`. `pip` will ensure that `numpy` is installed first so that it's detected and the releveant features/bindings/etc. are compiled and made available for users.
rouault
reviewed
Mar 1, 2020
| @@ -463,7 +463,8 @@ def parallel_build_extensions(self): | |||
| data_files=data_files, | |||
| ext_modules=ext_modules, | |||
| scripts=glob('scripts/*.py'), | |||
| cmdclass={'build_ext': gdal_ext} | |||
| cmdclass={'build_ext': gdal_ext}, | |||
| extras_require={'numpy': ['numpy > 1.0.0']}, | |||
There was a problem hiding this comment.
shouldn't that be conditionalized by if HAVE_NUMPY: ?
There was a problem hiding this comment.
No, it's the opposite: using pip install gdal[numpy] will install numpy, so that HAVE_NUMPY will be true when building/installing gdal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2158
Doing
pip install gdal[numpy]will installgdalwithnumpy > 1.0.0.pipwill ensure thatnumpyis installed first so that it's detectedand the releveant features/bindings/etc. are compiled and made available
for users.
FYI I did not touch how
numpywas installed in the various CI scripts, being a bit afraid of breaking things and/or making a mess.