-
Notifications
You must be signed in to change notification settings - Fork 18
do pending changes from merged PR about VIV #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 91.01% 90.86% -0.15%
==========================================
Files 131 127 -4
Lines 4998 4928 -70
==========================================
- Hits 4549 4478 -71
- Misses 449 450 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes, some comment for a follow up issue but LGTM
this PR includes the missing changes from PR #764 and thus, closes #767