Skip to content

Conversation

jorgepz
Copy link
Member

@jorgepz jorgepz commented Mar 17, 2025

this PR includes the missing changes from PR #764 and thus, closes #767

@jorgepz jorgepz requested a review from mvanzulli March 17, 2025 19:14
@jorgepz jorgepz marked this pull request as ready for review March 17, 2025 19:14
@jorgepz jorgepz marked this pull request as draft March 17, 2025 19:36
@jorgepz jorgepz marked this pull request as ready for review March 17, 2025 19:39
@jorgepz jorgepz changed the title pending changes from merged PR do pending changes from merged PR Mar 17, 2025
@jorgepz jorgepz changed the title do pending changes from merged PR do pending changes from merged PR about VIV Mar 17, 2025
@jorgepz jorgepz merged commit ace7c40 into master Mar 17, 2025
7 checks passed
@jorgepz jorgepz deleted the jorge branch March 17, 2025 20:40
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (1b98f89) to head (7f1331e).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
docs/src/bringONSASmFilesToONSASdocs.m 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   91.01%   90.86%   -0.15%     
==========================================
  Files         131      127       -4     
  Lines        4998     4928      -70     
==========================================
- Hits         4549     4478      -71     
- Misses        449      450       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mvanzulli mvanzulli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, some comment for a follow up issue but LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VIV case to drag reconfiguration example
2 participants