Skip to content

Fix formatting in examples #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Mar 9, 2025
Merged

Fix formatting in examples #748

merged 22 commits into from
Mar 9, 2025

Conversation

mvanzulli
Copy link
Member

@mvanzulli mvanzulli commented Mar 1, 2025 •
edited
Loading

Closes: #747
Closes: #752

CI job: https://github.com/ONSAS/ONSAS/actions/runs/13737558491/job/38423073813?pr=748

 ✘  mvanzulli   mvanzulli/747-fix-examples-format-issues -  make ci_checks
Installing dependencies...
poetry install
Installing dependencies from lock file

No dependencies to install or update
Checking code formatting in ./../docs/ ./../test/ ./../examples...
MISS_HIT Style Summary: 45 file(s) analysed, everything seems fine
✅ Formatting check passed!
Running lint checks on ./../docs/ ./../test/ ./../examples...
MISS_HIT Lint Summary: 45 file(s) analysed, everything seems fine
✅ Linting check passed!
Running code metrics for ./../docs/ ./../test/ ./../examples...
MISS_HIT Metric Summary: 45 file(s) analysed, everything seems fine
✅ Code metrics check passed!
✅ All checks passed successfully.
🎯 CI checks completed successfully.

@mvanzulli mvanzulli requested a review from jorgepz March 8, 2025 12:16
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.50136% with 83 lines in your changes missing coverage. Please review.

Project coverage is 90.09%. Comparing base (2b8567a) to head (55cd511).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
examples/linearAerodynamics/myLinearAeroLA.m 0.00% 32 Missing ⚠️
docs/src/m2md.m 0.00% 15 Missing ⚠️
.../dragBeamReconfiguration/dragBeamReconfiguration.m 97.77% 3 Missing ⚠️
...mples/dragBeamReconfiguration/windVelCircDynamic.m 0.00% 2 Missing ⚠️
examples/linearAerodynamics/dragCoefFunctionLA.m 60.00% 2 Missing ⚠️
examples/linearAerodynamics/liftCoefFunctionLA.m 60.00% 2 Missing ⚠️
examples/simplePropeller/simplePropeller.m 97.59% 2 Missing ⚠️
examples/springMass/springMass.m 98.63% 2 Missing ⚠️
examples/staticVonMisesTruss/myVMLoadFunc.m 0.00% 2 Missing ⚠️
examples/uniaxialCompression/uniaxialCompression.m 97.29% 2 Missing ⚠️
... and 18 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   90.16%   90.09%   -0.08%     
==========================================
  Files         130      130              
  Lines        4710     4946     +236     
==========================================
+ Hits         4247     4456     +209     
- Misses        463      490      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jorgepz
jorgepz approved these changes Mar 9, 2025
View reviewed changes
Copy link
Member

@jorgepz jorgepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome contributions Mauricio! We still need to update the metric parameters.

@jorgepz
Copy link
Member

jorgepz commented Mar 9, 2025 •
edited
Loading

I suggest to increase the cyclomatic and parameters for metrics in misshit, if not, a huge refactoring would be needed.

@jorgepz
Copy link
Member

jorgepz commented Mar 9, 2025

also suggest merging this #757

@mvanzulli mvanzulli merged commit 0b4eb13 into master Mar 9, 2025
7 checks passed
@mvanzulli mvanzulli deleted the mvanzulli/747-fix-examples-format-issues branch March 9, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepz jorgepz jorgepz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate static checks in CI Fix examples format
2 participants
@mvanzulli @jorgepz