-
Notifications
You must be signed in to change notification settings - Fork 18
a few edits in docs + include some FSI parameters as fields in structs #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Question: Is this MR trying to address only item 3 of #468 ? If that is the case, I can give it a try. I guess we already have an end-to-end test for the feature right ? |
yes @mvanzulli indeed this was intended to tackle only subtask 3. thanks for any contribution! |
Thanks for the clarification, will assign this to me whenever I have time to work on it, so I don't block progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
==========================================
- Coverage 89.46% 89.33% -0.13%
==========================================
Files 131 131
Lines 4661 4662 +1
==========================================
- Hits 4170 4165 -5
- Misses 491 497 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.