Skip to content

Conversation

jorgepz
Copy link
Member

@jorgepz jorgepz commented Oct 31, 2024

No description provided.

@mvanzulli
Copy link
Member

mvanzulli commented Nov 22, 2024

Question: Is this MR trying to address only item 3 of #468 ? If that is the case, I can give it a try. I guess we already have an end-to-end test for the feature right ?

@jorgepz jorgepz changed the title integrate VIV as a "native" feature integrate VIV as a native feature Nov 22, 2024
@jorgepz
Copy link
Member Author

jorgepz commented Nov 22, 2024

yes @mvanzulli indeed this was intended to tackle only subtask 3. thanks for any contribution!

@mvanzulli
Copy link
Member

yes @mvanzulli indeed this was intended to tackle only subtask 3. thanks for any contribution!

Thanks for the clarification, will assign this to me whenever I have time to work on it, so I don't block progress.

@jorgepz jorgepz changed the title integrate VIV as a native feature a few edits in docs + include some VIV parameters as fields in structs Mar 8, 2025
@jorgepz jorgepz marked this pull request as ready for review March 8, 2025 20:41
@jorgepz jorgepz changed the title a few edits in docs + include some VIV parameters as fields in structs a few edits in docs + include some FSI parameters as fields in structs Mar 8, 2025
@jorgepz jorgepz merged commit 2de8493 into master Mar 8, 2025
6 checks passed
@jorgepz jorgepz deleted the jorge branch March 8, 2025 22:01
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (f720a67) to head (87a327a).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   89.46%   89.33%   -0.13%     
==========================================
  Files         131      131              
  Lines        4661     4662       +1     
==========================================
- Hits         4170     4165       -5     
- Misses        491      497       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants