Skip to content

Fix aero force docs inconsistencies and check analysis settings struct #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 21, 2024
Merged

Fix aero force docs inconsistencies and check analysis settings struct #710

merged 12 commits into from
Jun 21, 2024

Conversation

mvanzulli
Copy link
Member

@mvanzulli mvanzulli commented Jun 9, 2024 •
edited
Loading

Addressing a subtask of #704
Closes #711

@mvanzulli mvanzulli changed the title Fix docs inconsitencies Fix docs inconsistencies Jun 9, 2024
@mvanzulli mvanzulli marked this pull request as draft June 9, 2024 19:32
@mvanzulli mvanzulli force-pushed the mvanzulli/704-fix-docs-inconsitencies branch from ea192a5 to 5c6a6b4 Compare June 14, 2024 22:22
@mvanzulli mvanzulli marked this pull request as ready for review June 14, 2024 22:35
@codecov Codecov
Copy link

codecov bot commented Jun 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (3703913) to head (8d62e0a).

❗ Current head 8d62e0a differs from pull request most recent head 8cf3a08

Please upload reports for the commit 8cf3a08 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   88.97%   89.00%   +0.03%     
==========================================
  Files         131      131              
  Lines        4491     4504      +13     
==========================================
+ Hits         3996     4009      +13     
  Misses        495      495

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jorgepz
jorgepz reviewed Jun 16, 2024
View reviewed changes
jorgepz
jorgepz reviewed Jun 16, 2024
View reviewed changes
jorgepz
jorgepz reviewed Jun 16, 2024
View reviewed changes
jorgepz
jorgepz reviewed Jun 16, 2024
View reviewed changes
mvanzulli and others added 3 commits June 17, 2024 08:49
@mvanzulli @jorgepz
Update creatingModels.md
6b668e1 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli @jorgepz
Update creatingModels.md
50cb3ba 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli @jorgepz
Update creatingModels.md
e42ac46 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
jorgepz
jorgepz reviewed Jun 17, 2024
View reviewed changes
jorgepz
jorgepz reviewed Jun 17, 2024
View reviewed changes
jorgepz
jorgepz reviewed Jun 17, 2024
View reviewed changes
mvanzulli and others added 4 commits June 17, 2024 22:09
@mvanzulli @jorgepz
Update VIVCantilever.m
b7fe676 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli @jorgepz
Update VIVCantilever.m
f85b84f 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli @jorgepz
Update VIVCantilever.m
6a896cf 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli
Revert num gauss aero (#704)
b545526
jorgepz
jorgepz approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@jorgepz jorgepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! The last change needed in order to close 704 is adding the analysisSettings and the new fields to the checkONSASFields function in

ONSAS/src/utils/checkONSASFields.m

Line 27 in 3703913

% checkFields(elements, {'elemType', 'elemTypeParams','massMatType',...
however, you can merge the PR and leave that for another one

@jorgepz
Copy link
Member

jorgepz commented Jun 20, 2024

Also the imposedDispDofs should be done in another PR, therefore I changed the description from closes to related to #704.

@mvanzulli mvanzulli changed the title Fix docs inconsistencies Fix aero force docs inconsistencies Jun 20, 2024
@mvanzulli
Copy link
Member Author

Great work, thanks! The last change needed in order to close 704 is adding the analysisSettings and the new fields to the checkONSASFields function in

ONSAS/src/utils/checkONSASFields.m

Line 27 in 3703913

% checkFields(elements, {'elemType', 'elemTypeParams','massMatType',...

however, you can merge the PR and leave that for another one

Let's do it here. I created a new issue for this since is a bit an extension of the one that I'm addressing #711

@mvanzulli mvanzulli requested a review from jorgepz June 20, 2024 21:59
mvanzulli
mvanzulli commented Jun 20, 2024
View reviewed changes
mvanzulli
mvanzulli commented Jun 20, 2024
View reviewed changes
@mvanzulli mvanzulli changed the title Fix aero force docs inconsistencies Fix aero force docs inconsistencies and check analysis settings struct Jun 20, 2024
@mvanzulli mvanzulli merged commit a01893f into master Jun 21, 2024
@mvanzulli mvanzulli deleted the mvanzulli/704-fix-docs-inconsitencies branch June 21, 2024 09:24
@mvanzulli mvanzulli mentioned this pull request Jun 21, 2024
Open
@jorgepz jorgepz mentioned this pull request Jun 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepz jorgepz jorgepz approved these changes

@santiago-correa-89 santiago-correa-89 Awaiting requested review from santiago-correa-89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check default parameters of analysisSettings struct
2 participants
@mvanzulli @jorgepz