Skip to content

Conversation

JoaquinViera
Copy link
Collaborator

An idea to issue #553
Comment @jorgepz @mvanzulli

@jorgepz
Copy link
Member

jorgepz commented Apr 10, 2023

Excellent! this seems a good idea. inside the function setDefaults you could add a loop to call that isONSASfield and this last function could have a list of possible fields.

you can use matlab/octaves builtin functions such as isfield ...

@jorgepz jorgepz changed the title an idea Add verification of fields defined for each input struct Aug 25, 2023
@jorgepz jorgepz marked this pull request as ready for review August 25, 2023 21:49
@jorgepz
Copy link
Member

jorgepz commented Aug 25, 2023

thanks for the idea @JoaquinViera

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2023

Codecov Report

Merging #654 (28c4495) into master (5d566a6) will increase coverage by 0.25%.
The diff coverage is 95.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   74.54%   74.80%   +0.25%     
==========================================
  Files         148      147       -1     
  Lines        4970     4949      -21     
==========================================
- Hits         3705     3702       -3     
+ Misses       1265     1247      -18     
Files Changed Coverage Δ
src/mesh/nodes2dofs.m 100.00% <ø> (ø)
src/utils/isThisOctave.m 100.00% <ø> (ø)
test/runTestProblems_local.m 0.00% <0.00%> (ø)
src/utils/checkONSASFields.m 90.00% <90.00%> (ø)
examples/VIVCantilever/VIVCantilever.m 98.41% <100.00%> (+0.37%) ⬆️
.../dragBeamReconfiguration/dragBeamReconfiguration.m 98.42% <100.00%> (ø)
examples/linearAerodynamics/linearAerodynamics.m 96.15% <100.00%> (-0.10%) ⬇️
examples/simplePropeller/simplePropeller.m 98.57% <100.00%> (-0.04%) ⬇️
src/core/ONSAS_init.m 92.06% <100.00%> (+0.12%) ⬆️
src/core/assembler.m 89.89% <100.00%> (-0.16%) ⬇️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jorgepz jorgepz merged commit 43d3ac1 into master Aug 26, 2023
@jorgepz jorgepz deleted the 553 branch August 26, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants