Skip to content

Correcting my error #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2023
Merged

Correcting my error #641

merged 1 commit into from
Mar 1, 2023

Conversation

TheChikenfly
Copy link
Collaborator

had a U^3 instead of U^2

@TheChikenfly
Correcting my error
4fb1b73 
had a U^3 instead of U^2
@TheChikenfly TheChikenfly requested a review from jorgepz February 28, 2023 22:16
jorgepz
jorgepz approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@jorgepz jorgepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@mvanzulli
Copy link
Member

Strange, why the tests didn't avoid this bug ? Its a very important factor in the fluid force.

@jorgepz
Copy link
Member

jorgepz commented Mar 1, 2023

Strange, why the tests didn't avoid this bug ? Its a very important factor in the fluid force.

I think it is because the error was in the experimental fluidFlowBool which i guess is not in the tests... That is being used only by Alexandre by the moment.

@TheChikenfly TheChikenfly merged commit 8a0bc95 into master Mar 1, 2023
@TheChikenfly TheChikenfly deleted the TheChikenfly-patch-1 branch March 1, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepz jorgepz jorgepz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheChikenfly @mvanzulli @jorgepz