Skip to content

IL VIV #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 27, 2023
Merged

IL VIV #622

merged 10 commits into from
Feb 27, 2023

Conversation

TheChikenfly
Copy link
Collaborator

No description provided.

@TheChikenfly TheChikenfly added the enhancement New feature or request label Feb 21, 2023
@TheChikenfly TheChikenfly requested a review from jorgepz February 21, 2023 20:35
@jorgepz
Copy link
Member

jorgepz commented Feb 21, 2023

Thanks @TheChikenfly . Are you planning to add a file WOM_IL.m ? Now I am seeing that there are some issues with the tests...

@TheChikenfly
Copy link
Collaborator Author

yes i am working on it it works locally I will make it work here

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023 •
edited
Loading

Codecov Report

Merging #622 (6a5b449) into master (c5934b5) will decrease coverage by 43.67%.
The diff coverage is 0.00%.

❗ Current head 6a5b449 differs from pull request most recent head f83c38c. Consider uploading reports for the commit f83c38c to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master     #622       +/-   ##
===========================================
- Coverage   60.76%   17.10%   -43.67%     
===========================================
  Files         147      148        +1     
  Lines        4868     4795       -73     
===========================================
- Hits         2958      820     -2138     
- Misses       1910     3975     +2065
Impacted Files Coverage Δ
src/elements/frame/WOM_IL.m 0.00% <0.00%> (ø)
src/elements/frame/frame_fluid_force.m 0.00% <0.00%> (-78.58%) ⬇️
src/elements/frame/integFluidForce.m 0.00% <0.00%> (-84.00%) ⬇️
src/analyDet.m 0.00% <0.00%> (-100.00%) ⬇️
src/isThisOctave.m 0.00% <0.00%> (-100.00%) ⬇️
src/vtk/frameVtkData.m 0.00% <0.00%> (-100.00%) ⬇️
src/vtk/trussVtkData.m 0.00% <0.00%> (-100.00%) ⬇️
src/vtk/vtkMainWriter.m 0.00% <0.00%> (-100.00%) ⬇️
src/complexStepConsMat.m 0.00% <0.00%> (-100.00%) ⬇️
src/elements/frame/WOMV4.m 0.00% <0.00%> (-100.00%) ⬇️
... and 73 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jorgepz jorgepz marked this pull request as ready for review February 22, 2023 14:10
@jorgepz
Copy link
Member

jorgepz commented Feb 22, 2023

I assume that the PR is ready for review... thus I changed the status

@TheChikenfly
Copy link
Collaborator Author

Yes it is thanks

jorgepz
jorgepz reviewed Feb 22, 2023
View reviewed changes
@TheChikenfly TheChikenfly marked this pull request as draft February 22, 2023 18:16
@TheChikenfly TheChikenfly marked this pull request as ready for review February 27, 2023 19:38
jorgepz
jorgepz approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@jorgepz jorgepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent! great contribution!

@TheChikenfly TheChikenfly merged commit dc5996c into master Feb 27, 2023
@TheChikenfly TheChikenfly deleted the IL_VIV branch February 27, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepz jorgepz jorgepz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheChikenfly @jorgepz @codecov-commenter