Skip to content

Fix userFlowVel calls in frame_fluid_force for non uniform flows #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2022
Merged

Fix userFlowVel calls in frame_fluid_force for non uniform flows #570

merged 1 commit into from
Sep 28, 2022

Conversation

TheChikenfly
Copy link
Collaborator

@TheChikenfly TheChikenfly commented Sep 28, 2022 •
edited
Loading

I would like to have the node coordinates in userFlowVel but as it is called it gives something else, I don't know if it is done on purpose or if it is a mistake

mvanzulli
mvanzulli approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@mvanzulli mvanzulli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! This feature is not tested since any velocity field depends on $$x$$

@TheChikenfly TheChikenfly merged commit 37d25bd into master Sep 28, 2022
@TheChikenfly TheChikenfly deleted the fix_userFlowVel_call branch September 28, 2022 15:42
@jorgepz
Copy link
Member

jorgepz commented Sep 28, 2022

thanks for the fix @TheChikenfly !! 🏃🏼 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvanzulli mvanzulli mvanzulli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheChikenfly @jorgepz @mvanzulli