Skip to content

adding example cylindrical linear plane strain example into docs #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 21, 2022
Merged

adding example cylindrical linear plane strain example into docs #490

merged 16 commits into from
May 21, 2022

Conversation

mvanzulli
Copy link
Member

@mvanzulli mvanzulli commented May 18, 2022 •
edited
Loading

This PR closes #489

@mvanzulli mvanzulli changed the title adding example cylindrical linear plane strain into docs adding example cylindrical linear plane strain example into docs May 18, 2022
@jorgepz
Copy link
Member

jorgepz commented May 19, 2022

Ojo con las carpetas aux... Me parece que tenes que actualizar el repo...

@mvanzulli mvanzulli requested a review from jorgepz May 19, 2022 16:21
@mvanzulli mvanzulli marked this pull request as ready for review May 19, 2022 16:21
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
@jorgepz
Copy link
Member

jorgepz commented May 19, 2022

Me parece q el sistema de coord no es directo

@mvanzulli @jorgepz
Update examples/linearCylinderPlaneStrain/linearCylinderPlaneStrain.m
b21f59c 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli
Copy link
Member Author

Ojo con las carpetas aux... Me parece que tenes que actualizar el repo...
Eliminadas

@jorgepz
Copy link
Member

jorgepz commented May 19, 2022

sugiero poner fondos blancos a la imagen svg y a la de la malla en gmsh

jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
jorgepz
jorgepz reviewed May 19, 2022
View reviewed changes
Copy link
Member

@jorgepz jorgepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

propongo cambios

jorgepz
jorgepz reviewed May 20, 2022
View reviewed changes
mvanzulli and others added 5 commits May 19, 2022 21:36
@mvanzulli @jorgepz
Update examples/linearCylinderPlaneStrain/linearCylinderPlaneStrain.m
7cc6d76 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli @jorgepz
Update examples/linearCylinderPlaneStrain/linearCylinderPlaneStrain.m
f5a1856 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli @jorgepz
Update examples/linearCylinderPlaneStrain/linearCylinderPlaneStrain.m
a96b6d8 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli @jorgepz
Update examples/linearCylinderPlaneStrain/linearCylinderPlaneStrain.m
99f3a8e 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
solving jorge comments
5804e8f
@jorgepz
Copy link
Member

jorgepz commented May 20, 2022

I suggest you to resolve the conversations u consider that are...

jorgepz
jorgepz approved these changes May 21, 2022
View reviewed changes
Copy link
Member

@jorgepz jorgepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selente

@mvanzulli mvanzulli merged commit 0711e1c into master May 21, 2022
@jorgepz jorgepz deleted the mvanzulli/cylinderPlaneStrain branch May 21, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepz jorgepz jorgepz approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add and validate linear plane strain example into docs
2 participants
@mvanzulli @jorgepz