Skip to content

Conversation

mvanzulli
Copy link
Member

@mvanzulli mvanzulli commented May 16, 2022

This PR closes #480

@jorgepz jorgepz changed the title Mvanzulli/cleaning funcs organization and cleaning of several functions May 16, 2022
@jorgepz
Copy link
Member

jorgepz commented May 16, 2022

As we just discussed, I agree that DXF files are not in our current focus/scope, then I agree to remove those functions. I suggest you also moving S. Toro from author of code to contributor of ONSAS (as former author of code), since no developments were done over his code contributions (in accordance with #447 ) . This edition should be done in the Readme.md , the docs/index.md , citation.aff and the DESCRIPTION files.

@mvanzulli
Copy link
Member Author

As we just discussed, I agree that DXF files are not in our current focus/scope, then I agree to remove those functions. I suggest you also moving S. Toro from author of code to contributor of ONSAS (as former author of code), since no developments were done over his code contributions (in accordance with #447 ) . This edition should be done in the Readme.md , the docs/index.md and the DESCRIPTION files.

Ok, done

@jorgepz
Copy link
Member

jorgepz commented May 16, 2022

Thanks. Let me know when the pr is ready for review...

@mvanzulli mvanzulli marked this pull request as ready for review May 16, 2022 20:44
@mvanzulli mvanzulli requested a review from jorgepz May 16, 2022 20:44
@mvanzulli
Copy link
Member Author

mvanzulli commented May 16, 2022

Thanks. Let me know when the pr is ready for review...

Now it is, check the new folders tree.

Copy link
Member

@jorgepz jorgepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

estoy armando PR con cambios propuestos... de todas formas el orden de los autores no coincide con el del citation.aff

@jorgepz
Copy link
Member

jorgepz commented May 16, 2022

i already updated the citation file in #485 ... i'll try to fix the conflict...

@mvanzulli
Copy link
Member Author

i already updated the citation file in #485 ... i'll try to fix the conflict...

Sorry I misunderstood, I can also delete the last commit of this branch by using:

git reset --hard HEAD~1
git push --force

@jorgepz
Copy link
Member

jorgepz commented May 16, 2022

no worries it is fixed... i think // no hay problema

corrijo algunos encabezados a mano y agrego script para generación automática
@jorgepz jorgepz self-requested a review May 16, 2022 23:01
@mvanzulli mvanzulli merged commit fda92e3 into master May 16, 2022
@mvanzulli mvanzulli deleted the mvanzulli/cleaningFuncs branch May 16, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean currently not used functions
2 participants