-
Notifications
You must be signed in to change notification settings - Fork 18
organization and cleaning of several functions #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As we just discussed, I agree that DXF files are not in our current focus/scope, then I agree to remove those functions. I suggest you also moving S. Toro from author of code to contributor of ONSAS (as former author of code), since no developments were done over his code contributions (in accordance with #447 ) . This edition should be done in the Readme.md , the docs/index.md , citation.aff and the DESCRIPTION files. |
Ok, done |
Thanks. Let me know when the pr is ready for review... |
Now it is, check the new folders tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
estoy armando PR con cambios propuestos... de todas formas el orden de los autores no coincide con el del citation.aff
i already updated the citation file in #485 ... i'll try to fix the conflict... |
Sorry I misunderstood, I can also delete the last commit of this branch by using: git reset --hard HEAD~1
git push --force |
no worries it is fixed... i think // no hay problema |
corrijo algunos encabezados a mano y agrego script para generación automática
This PR closes #480