Skip to content

Conversation

siko1056
Copy link
Contributor

@siko1056 siko1056 commented Feb 9, 2022

Add missing field "Categories" and use "Date" format "YYYY-MM-DD".

Add missing field "Categories" and use "Date" format "YYYY-MM-DD".
@jorgepz
Copy link
Member

jorgepz commented Feb 9, 2022

Thanks for the contribution!! I used a format compatible with the octave documentation http://octave.org/doc/v6.4.0/The-DESCRIPTION-File.html#The-DESCRIPTION-File which is the correct one?

@siko1056
Copy link
Contributor Author

siko1056 commented Feb 9, 2022

Sorry, then it should be the one from the manual. The truth is, it is not specified 😓

Can you edit my PR?

Update date format to merge siko1056 contribution
@jorgepz jorgepz merged commit fda06e8 into ONSAS:master Feb 9, 2022
@jorgepz
Copy link
Member

jorgepz commented Feb 9, 2022

Sorry, then it should be the one from the manual. The truth is, it is not specified 😓

Can you edit my PR?

Mauricio fixed it. Then, since no specification of date is set, we left the documentation format.

@siko1056 thanks for your contribution. I think it would be a good idea to adopt a standard such as https://es.wikipedia.org/wiki/ISO_8601 I guess we could open an issue at some octave repo...

@siko1056 siko1056 deleted the patch-1 branch February 10, 2022 02:01
@siko1056
Copy link
Contributor Author

@jorgepz and @mvanzulli Thank for fixing and merging my PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants