Strong name signing #647
Merged
Strong name signing #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gonna need to call in the Cavalry for this.
robertmclaws
pushed a commit
that referenced
this pull request
Sep 18, 2019
* Removed ApplyTo methods and using Microsoft.Extensions.DependencyInjection statements from Conventions classes. Fixes #1 * Made conventionbased classes public. Fixes jspuij#2. * Moved extensions methods into the Invocation context. References jspuij#5. * Remove enumeration GetApiService as it isn't used anywhere. References jspuij#5 * Created constructor parameters for DefaultSubmitHandler. Closes jspuij#6. * Fixed unit tests. As IChangeSetInitializer and ISubmitExecutor instances now need to be resolved by the DI container on creation of an ApiBase descendant, you must register implementations. * Made ServiceProvider private. Fixes jspuij#9. * Added a reference to an ApiBase instance in InvocationContext. References jspuij#10 * Replaced DI calls to ApiBase with a reference. Fixes jspuij#10 * Replaced a few GetApiService calls with constructor injection. References: jspuij#16 * Get the model from the API using GetModelAsync. References jspuij#16. * Added constructor arguments to DefaultQueryHandler. References jspuij#17 * Fixed unit tests. earlier dependency checks. References jspuij#17 * Changed ApiBase to a constructor dependency for RestierBatchChangeSetRequestItem. References jspuij#21 * Replaced Service location on Restier Serializers with constructor arguments. Fixes jspuij#22. * Replaced IServiceProvider with IEdmModel in EdmHelpers. Fixes jspuij#23. * Move ApplyTo To ServiceCollectionExtensions. Fixes jspuij#25 * Moved RestierOperationModelBuilder.ApplyTo to ServiceCollectionExtensions. Fixes jspuij#26. * Removed dependency on Microsoft.Extensions.DependencyInection. References jspuij#27 * Creates constructor arguments for RestierController. References jspuij#27. * Introduced interface for DbContext. References jspuij#19 * Added await to pre- and postevents. Fixes jspuij#15. * Don't get the provider from the request message if all constructor arguments are supplied. * Revert "Introduced interface for DbContext." This reverts commit 39e5208. * Replace IEdmModel lookup with constructor argument. Fixes jspuij#32. * - Updating to latest OData packages - Adding Authenticode signing - Removing legacy test projects. * More project cleanup. * Adding global.json * Strong name signing (#647) * Attempt to get strong name signing working Gonna need to call in the Cavalry for this. * Strong name key signing (unfortunately breaks unit tests). * Updating to the new logo system to fix the unnecessary iconurl deprecation. * Update Breakdance to a strong-named version so that the tests compile again. * Removed ApplyTo methods and using Microsoft.Extensions.DependencyInjection statements from Conventions classes. Fixes #1 * Made conventionbased classes public. Fixes jspuij#2. * Moved extensions methods into the Invocation context. References jspuij#5. * Remove enumeration GetApiService as it isn't used anywhere. References jspuij#5 * Created constructor parameters for DefaultSubmitHandler. Closes jspuij#6. * Fixed unit tests. As IChangeSetInitializer and ISubmitExecutor instances now need to be resolved by the DI container on creation of an ApiBase descendant, you must register implementations. * Made ServiceProvider private. Fixes jspuij#9. * Added a reference to an ApiBase instance in InvocationContext. References jspuij#10 * Replaced DI calls to ApiBase with a reference. Fixes jspuij#10 * Replaced a few GetApiService calls with constructor injection. References: jspuij#16 * Get the model from the API using GetModelAsync. References jspuij#16. * Added constructor arguments to DefaultQueryHandler. References jspuij#17 * Fixed unit tests. earlier dependency checks. References jspuij#17 * Changed ApiBase to a constructor dependency for RestierBatchChangeSetRequestItem. References jspuij#21 * Replaced Service location on Restier Serializers with constructor arguments. Fixes jspuij#22. * Replaced IServiceProvider with IEdmModel in EdmHelpers. Fixes jspuij#23. * Move ApplyTo To ServiceCollectionExtensions. Fixes jspuij#25 * Moved RestierOperationModelBuilder.ApplyTo to ServiceCollectionExtensions. Fixes jspuij#26. * Removed dependency on Microsoft.Extensions.DependencyInection. References jspuij#27 * Creates constructor arguments for RestierController. References jspuij#27. * Introduced interface for DbContext. References jspuij#19 * Added await to pre- and postevents. Fixes jspuij#15. * Don't get the provider from the request message if all constructor arguments are supplied. * Revert "Introduced interface for DbContext." This reverts commit 39e5208. * Replace IEdmModel lookup with constructor argument. Fixes jspuij#32. * PR Adjustments - Making DbContext public again (EasyAF uses it extensively) - Make the sample app run again.
robertmclaws
added a commit
that referenced
this pull request
Dec 19, 2022
* Attempt to get strong name signing working Gonna need to call in the Cavalry for this. * Strong name key signing (unfortunately breaks unit tests).
robertmclaws
pushed a commit
that referenced
this pull request
Dec 19, 2022
* Removed ApplyTo methods and using Microsoft.Extensions.DependencyInjection statements from Conventions classes. Fixes #1 * Made conventionbased classes public. Fixes jspuij#2. * Moved extensions methods into the Invocation context. References jspuij#5. * Remove enumeration GetApiService as it isn't used anywhere. References jspuij#5 * Created constructor parameters for DefaultSubmitHandler. Closes jspuij#6. * Fixed unit tests. As IChangeSetInitializer and ISubmitExecutor instances now need to be resolved by the DI container on creation of an ApiBase descendant, you must register implementations. * Made ServiceProvider private. Fixes jspuij#9. * Added a reference to an ApiBase instance in InvocationContext. References jspuij#10 * Replaced DI calls to ApiBase with a reference. Fixes jspuij#10 * Replaced a few GetApiService calls with constructor injection. References: jspuij#16 * Get the model from the API using GetModelAsync. References jspuij#16. * Added constructor arguments to DefaultQueryHandler. References jspuij#17 * Fixed unit tests. earlier dependency checks. References jspuij#17 * Changed ApiBase to a constructor dependency for RestierBatchChangeSetRequestItem. References jspuij#21 * Replaced Service location on Restier Serializers with constructor arguments. Fixes jspuij#22. * Replaced IServiceProvider with IEdmModel in EdmHelpers. Fixes jspuij#23. * Move ApplyTo To ServiceCollectionExtensions. Fixes jspuij#25 * Moved RestierOperationModelBuilder.ApplyTo to ServiceCollectionExtensions. Fixes jspuij#26. * Removed dependency on Microsoft.Extensions.DependencyInection. References jspuij#27 * Creates constructor arguments for RestierController. References jspuij#27. * Introduced interface for DbContext. References jspuij#19 * Added await to pre- and postevents. Fixes jspuij#15. * Don't get the provider from the request message if all constructor arguments are supplied. * Revert "Introduced interface for DbContext." This reverts commit 39e5208. * Replace IEdmModel lookup with constructor argument. Fixes jspuij#32. * - Updating to latest OData packages - Adding Authenticode signing - Removing legacy test projects. * More project cleanup. * Adding global.json * Strong name signing (#647) * Attempt to get strong name signing working Gonna need to call in the Cavalry for this. * Strong name key signing (unfortunately breaks unit tests). * Updating to the new logo system to fix the unnecessary iconurl deprecation. * Update Breakdance to a strong-named version so that the tests compile again. * Removed ApplyTo methods and using Microsoft.Extensions.DependencyInjection statements from Conventions classes. Fixes #1 * Made conventionbased classes public. Fixes jspuij#2. * Moved extensions methods into the Invocation context. References jspuij#5. * Remove enumeration GetApiService as it isn't used anywhere. References jspuij#5 * Created constructor parameters for DefaultSubmitHandler. Closes jspuij#6. * Fixed unit tests. As IChangeSetInitializer and ISubmitExecutor instances now need to be resolved by the DI container on creation of an ApiBase descendant, you must register implementations. * Made ServiceProvider private. Fixes jspuij#9. * Added a reference to an ApiBase instance in InvocationContext. References jspuij#10 * Replaced DI calls to ApiBase with a reference. Fixes jspuij#10 * Replaced a few GetApiService calls with constructor injection. References: jspuij#16 * Get the model from the API using GetModelAsync. References jspuij#16. * Added constructor arguments to DefaultQueryHandler. References jspuij#17 * Fixed unit tests. earlier dependency checks. References jspuij#17 * Changed ApiBase to a constructor dependency for RestierBatchChangeSetRequestItem. References jspuij#21 * Replaced Service location on Restier Serializers with constructor arguments. Fixes jspuij#22. * Replaced IServiceProvider with IEdmModel in EdmHelpers. Fixes jspuij#23. * Move ApplyTo To ServiceCollectionExtensions. Fixes jspuij#25 * Moved RestierOperationModelBuilder.ApplyTo to ServiceCollectionExtensions. Fixes jspuij#26. * Removed dependency on Microsoft.Extensions.DependencyInection. References jspuij#27 * Creates constructor arguments for RestierController. References jspuij#27. * Introduced interface for DbContext. References jspuij#19 * Added await to pre- and postevents. Fixes jspuij#15. * Don't get the provider from the request message if all constructor arguments are supplied. * Revert "Introduced interface for DbContext." This reverts commit 39e5208. * Replace IEdmModel lookup with constructor argument. Fixes jspuij#32. * PR Adjustments - Making DbContext public again (EasyAF uses it extensively) - Make the sample app run again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds strong name signing to the project, to confirm with Microsoft guidelines on shipping OSS (https://docs.microsoft.com/en-us/dotnet/standard/assembly/strong-named).
Issue:
There is a semi-circular dependency between this project and Breakdance. The tests depend on
Breakdance,Restier(which is not strong-name signed at this moment), andBreakdance.Restierdepends onMicrosoft.Restier.AspNet. I had to disable the unit tests for this build so that a Strong Named version can get up to NuGet, so I can sign Breakdance. Then I should be able to run the tests.🤔😆🤔🤞🤷♂️