[IMP] add xml-oe-structure-missing-id check #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you review @moylop260 @luisg123v |
luisg123v
suggested changes
Jun 23, 2023
98750ae to
8f8cf88
Compare
|
Thanks for the review @luisg123v, I've made the corrections |
|
Could you re-check it, please? |
8f8cf88 to
bb4623d
Compare
Closes OCA#27. This checks generates a message whenever a tag with 'oe_structure' in its classes has no id attribute.
|
/ocabot merge nobump |
|
Sorry @luisg123v you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
Don't blame me for trying 😄 |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27.
This checks generates a message whenever a tag with 'oe_structure' in its classes has no id attribute.