feat: remove build logic from test clients #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔥 This seems to make things even faster! Having already compiled the solution beforehand, and now just opening neovim to discover the tests brings this all the way down to from ~20 seconds to ~8 seconds! If I for example make a small edit in my test, before making neotest start to discover the tests, it takes ~16 seconds or so, so still ~4 seconds faster or so with my very limited "benchmarking" of just timing it with a stopwatch |
|
Awesome 🙌🏻 I'll get this merged in then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the test clients so its easier to determine if a rebuild should happen.
Mostly, this enables us to run test discovery without triggering a project build on initial discovery.
In this case I've opted to build the entire solution on startup.
I don't know if this have any improvements for you @seblyng compared to building the projects individually?