Detach worker threads #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker threads are created and never referenced. They can be safely detached with SDL_DetachThread. This fixes these warnings displayed upon exiting vkquake when run using sdl2-compat (SDL2 compatibility layer that uses SDL3 behind the scenes) used by some Linux distros: INFO: Leaked thread (0x55ad3e03cc20) (repeated for each thread)
|
@bubbleguuum Thanks, looks like it works on my side (Win10 x64) as for Linux I'll have to trust you. |
|
Confirming I tested on Linux, on openSUSE Tumbleweed using sdl2-compat meaning SDL3. SDL3 now displays "Leaked thread" warnings on |
|
This is good to go then |
j4reporting
pushed a commit
to j4reporting/vkQuake
that referenced
this pull request
May 3, 2025
* Detach worker threads Worker threads are created and never referenced. They can be safely detached with SDL_DetachThread. This fixes these warnings displayed upon exiting vkquake when run using sdl2-compat (SDL2 compatibility layer that uses SDL3 behind the scenes) used by some Linux distros: INFO: Leaked thread (0x55ad3e03cc20) (repeated for each thread) * Fix spacing * Do not store invalid SDL_Thread after detach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worker threads are created and never referenced.
They can be safely detached with SDL_DetachThread.
This fixes these warnings displayed upon exiting vkquake when run using sdl2-compat (SDL2 compatibility layer that uses SDL3 behind the scenes) used by some Linux distros:
INFO: Leaked thread (0x55ad3e03cc20)
(repeated for each thread)