fix for labeling new torrents #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohenk
reviewed
May 17, 2025
| @@ -230,15 +230,15 @@ function makeContent() { | |||
| req.push('not_add_path=1'); | |||
| if($("#randomize_hash").prop("checked")) | |||
| req.push('randomize_hash=1'); | |||
| var dirEle = $$("#dir_edit"); | |||
There was a problem hiding this comment.
Just remove # which is not needed, it should var dirEle = $$("dir_edit");.
There was a problem hiding this comment.
tested and it works, but val() did not work like it was before.
There was a problem hiding this comment.
tested and it works, but val() did not work like it was before.
It's not a JQuery object so, val() won't work.
tohenk
reviewed
May 17, 2025
| if(dir.length) | ||
| req.push('dir_edit='+encodeURIComponent(dir)); | ||
| } | ||
| var lblEle = $$("#tadd_label") |
2 tasks
|
Thanks! |
stickz
added a commit
to stickz/docker-rtorrent-rutorrent
that referenced
this pull request
May 17, 2025
**Full Changelog**: Novik/ruTorrent@v5.2.4...v5.2.5 # ruTorrent v5.2.5 This is a critical hotfix. It's highly recommended to upgrade. It fixes applying labels to new torrents. The error behavior is also reverted based on community feedback. ## What's Changed * Restore the original behavior of "Error" state based on community feedback by gashtal in Novik/ruTorrent#2923 * fix for labeling new torrents by ranirahn in Novik/ruTorrent#2925
stickz
added a commit
to stickz/docker-rutorrent
that referenced
this pull request
May 17, 2025
**Full Changelog**: Novik/ruTorrent@v5.2.4...v5.2.5 # ruTorrent v5.2.5 This is a critical hotfix. It's highly recommended to upgrade. It fixes applying labels to new torrents. The error behavior is also reverted based on community feedback. ## What's Changed * Restore the original behavior of "Error" state based on community feedback by gashtal in Novik/ruTorrent#2923 * fix for labeling new torrents by ranirahn in Novik/ruTorrent#2925
stickz
pushed a commit
that referenced
this pull request
May 17, 2025
* fix for this #2920 * Update content.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason $$ cant get the values. Maybe in the future someone finds better solution why its not working, but directly getting the value with getElementById works.