Add danger color to #randomize_hash #2875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The torrent add dialog #tadd remembers previous settings now to help users avoid needing to set the same setting repeatedly. Users also assume that default settings are always safe settings for general usage, and click through without reviewing them. A user who checks #randomize_hash for one torrent (deliberately or otherwise), then is surprised that none of their torrents download anymore, because #randomize_hash is still checked on all future torrent additions. Because users may legitimately want this setting to persist through several subequent torrent adds, we don't want to remove persistence for this field. But I think we should draw more attention to its use, because accidental usage can cause the entire client to stop functioning as expected (from a user perspective).
|
Thanks, confirmed working. |
stickz
pushed a commit
that referenced
this pull request
Mar 23, 2025
The torrent add dialog #tadd remembers previous settings now to help users avoid needing to set the same setting repeatedly. Users also assume that default settings are always safe settings for general usage, and click through without reviewing them. A user who checks #randomize_hash for one torrent (deliberately or otherwise), then is surprised that none of their torrents download anymore, because #randomize_hash is still checked on all future torrent additions. Because users may legitimately want this setting to persist through several subequent torrent adds, we don't want to remove persistence for this field. But I think we should draw more attention to its use, because accidental usage can cause the entire client to stop functioning as expected (from a user perspective).
stickz
added a commit
to stickz/docker-rtorrent-rutorrent
that referenced
this pull request
Apr 27, 2025
**Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.1 # ruTorrent v5.2.1 This is a critical hotfix to resolve breakage of RSS feeds. It's highly recommended to upgrade. In addition, the white border is fixed on dark themes. A stopped state is also added to torrents. ## What's Changed * Adding Stopped state by ranirahn in Novik/ruTorrent#2893 * Fix for broken RSS feeds break the rutorrent. by ranirahn in Novik/ruTorrent#2894 * Fix white border in dark themes by drrako in Novik/ruTorrent#2898 **Full Changelog**: Novik/ruTorrent@v5.2.0...v5.2.1 # ruTorrent v5.2.0 is now Stable This is a release contains more mobile design improvements, performance improvements and various new features. It builds on progress made in ruTorrent `v5.1` toward mobile development. ## Critical Improvement Summary 1. Torrents now have bigger font to make them easier to read. 2. There is no more drag mask when moving around dialog boxes. 3. Internet explorer is no longer supported. (Yes finally, we dropped it) 4. Various performance improvements to tables to improve responsiveness. 5. The clear log now has a bootstrap button in the bottom right corner. 6. Many other smaller improvements, bug fixes and new features. ## What's Changed * Fix torrent deleted without confirmation by koblack in Novik/ruTorrent#2804 * filedrop plugin: support dropped links by pekman in Novik/ruTorrent#2806 * Remove drag mask object by jevenski in Novik/ruTorrent#2805 * Covert clear log to a floating button by jevenski in Novik/ruTorrent#2810 * Use bootstrap dropdown on recent trackers by jevenski in Novik/ruTorrent#2809 * Use flex layout on context menu items by jevenski in Novik/ruTorrent#2812 * Adjust status bar and top menu by jevenski in Novik/ruTorrent#2813 * Define dialog window colors using variables by jevenski in Novik/ruTorrent#2815 * Distribute WebUi space using flex layout by jevenski in Novik/ruTorrent#2826 * Remove Internet Explorer support, and some useragent sniffing hacks by anthonyryan1 in Novik/ruTorrent#2825 * Change various s-table methods by jevenski in Novik/ruTorrent#2821 * Define status bar icons using base64 strings by jevenski in Novik/ruTorrent#2833 * Animate category panel by jevenski in Novik/ruTorrent#2831 * Define getter functions on s-table by jevenski in Novik/ruTorrent#2830 * Use bootstrap list group on options window by jevenski in Novik/ruTorrent#2819 * Define s-table header styles using variables by jevenski in Novik/ruTorrent#2836 * Improve s-table column resizing by jevenski in Novik/ruTorrent#2837 * Control alternate row color using CSS by jevenski in Novik/ruTorrent#2841 * Improve move column function by jevenski in Novik/ruTorrent#2844 * Improve s-table header row hover event handler by jevenski in Novik/ruTorrent#2851 * Drag and drop s-table header using DnD class by jevenski in Novik/ruTorrent#2855 * Merge stable head and body into one table by jevenski in Novik/ruTorrent#2860 * Add danger color to #randomize_hash by anthonyryan1 in Novik/ruTorrent#2875 * Fix various bugs for v5.2 by jevenski in Novik/ruTorrent#2863 * Let rutracker_check ignore torrents with certain labels by drrako in Novik/ruTorrent#2866 * Add "::1" to localhost address list. by rozhuk-im in Novik/ruTorrent#2881 * Improve $tempDirectory handling: by rozhuk-im in Novik/ruTorrent#2880 * Diskspace option to display free bytes (new pull request against develop branch) by TheGoblinHero in Novik/ruTorrent#2890 * Add a permission to hide all torrent options by fffe in Novik/ruTorrent#2868 * Mark ruTorrent v5.2 as Stable by stickz in Novik/ruTorrent#2891 ## New Contributors * pekman made their first contribution in Novik/ruTorrent#2806 * rozhuk-im made their first contribution in Novik/ruTorrent#2881 **Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The torrent add dialog #tadd remembers previous settings now to help users avoid needing to set the same setting repeatedly.
Users also assume that default settings are always safe settings for general usage, and click through without reviewing them.
A user who checks #randomize_hash for one torrent (deliberately or otherwise), then is surprised that none of their torrents download anymore, because #randomize_hash is still checked on all future torrent additions.
Because users may legitimately want this setting to persist through several subequent torrent adds, we don't want to remove persistence for this field. But I think we should draw more attention to its use, because accidental usage can cause the entire client to stop functioning as expected (from a user perspective).