-
Notifications
You must be signed in to change notification settings - Fork 43
Add codesize
and codecopy
yul builtins
#1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codesize
and codecopy
yul builtins
#1314
Conversation
🦋 Changeset detectedLatest commit: 53e4f12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Can you add the two built-ins to the yul/all_built_ins
bindings snapshot test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Co-authored-by: Omar Tawfik <15987992+OmarTawfik@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/slang@1.2.0 ### Minor Changes - [#1330](#1330) [`56393d5`](56393d5) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for Solidity `0.8.30` ### Patch Changes - [#1314](#1314) [`743d6b0`](743d6b0) Thanks [@mjoerussell](https://github.com/mjoerussell)! - Adding missing YUL built in functions: - `codesize()` - `codecopy(f, t, s)` Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
These two yul builtins are missing from the language definition:
codesize()
codecopy(t, f, s)