Skip to content

Conversation

mjoerussell
Copy link
Contributor

These two yul builtins are missing from the language definition:

  1. codesize()
  2. codecopy(t, f, s)

@mjoerussell mjoerussell requested review from a team as code owners April 28, 2025 16:57
Copy link

changeset-bot bot commented Apr 28, 2025

🦋 Changeset detected

Latest commit: 53e4f12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/slang Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ggiraldez ggiraldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you add the two built-ins to the yul/all_built_ins bindings snapshot test?

Copy link
Contributor

@ggiraldez ggiraldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Co-authored-by: Omar Tawfik <15987992+OmarTawfik@users.noreply.github.com>
@mjoerussell mjoerussell added this pull request to the merge queue Apr 29, 2025
Merged via the queue into NomicFoundation:main with commit 743d6b0 Apr 29, 2025
2 checks passed
@mjoerussell mjoerussell deleted the feature/more-yul-builtins branch April 29, 2025 18:05
@github-actions github-actions bot mentioned this pull request Apr 29, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 22, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @nomicfoundation/slang@1.2.0

### Minor Changes

- [#1330](#1330)
[`56393d5`](56393d5)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add support for
Solidity `0.8.30`

### Patch Changes

- [#1314](#1314)
[`743d6b0`](743d6b0)
Thanks [@mjoerussell](https://github.com/mjoerussell)! - Adding missing
YUL built in functions:

    -   `codesize()`
    -   `codecopy(f, t, s)`

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants