Skip to content

Conversation

OmarTawfik
Copy link
Contributor

@OmarTawfik OmarTawfik commented Jan 21, 2025

  • add TerminalKindExtensions.is_identifier() API to distinguish terminals like Solidity's Identifier and Yul's YulIdentifier.
  • split parser/Parser.supportedVersions() into a new utils/LanguageFacts API, with allVersions(), earliestVersion(), and latestVersion() methods.
  • rename Query.parse() to Query.create(), and provide exact TextRange for any errors it returns.
  • split Parser.parse() API into parse_file_contents() and parse_nonterminal().

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: e6f6c7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/slang Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OmarTawfik OmarTawfik changed the title add missing APIs API improvements Jan 21, 2025
@OmarTawfik OmarTawfik force-pushed the add-missing-apis branch 4 times, most recently from 06ce958 to 8ec87b2 Compare January 22, 2025 10:56
@OmarTawfik OmarTawfik marked this pull request as ready for review January 22, 2025 11:05
@OmarTawfik OmarTawfik requested review from a team as code owners January 22, 2025 11:05
Copy link
Contributor

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! I'm just not convinced of the parse_file name, but otherwise, this is good to go.

@OmarTawfik OmarTawfik enabled auto-merge January 24, 2025 08:21
@OmarTawfik OmarTawfik added this pull request to the merge queue Jan 24, 2025
Merged via the queue into NomicFoundation:main with commit 3e85a14 Jan 24, 2025
1 check passed
@OmarTawfik OmarTawfik deleted the add-missing-apis branch January 24, 2025 09:12
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @nomicfoundation/slang@0.19.0

### Minor Changes

- [#1156](#1156)
[`3a82f06`](3a82f06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add
`node.descendants()` and `cursor.descendants()` APIs to allow iterating
over all descendants of the current node in pre-order traversal.

- [#1156](#1156)
[`3a82f06`](3a82f06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fix
`node.children()` and `parseOutput.errors()` return types

- [#1194](#1194)
[`7a25d63`](7a25d63)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - split
`parser/Parser.supportedVersions()` into a new `utils/LanguageFacts`
API, with `allVersions()`, `earliestVersion()`, and `latestVersion()`
methods.

- [#1194](#1194)
[`7a25d63`](7a25d63)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - expose the
`BingingGraph` API to allow querying definitions/references between
source files.

- [#1156](#1156)
[`3a82f06`](3a82f06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add
`cursor.ancestors()` API to allow iterating over all ancestors of the
current node, starting with the immediate parent, and moving upwards,
ending with the root node.

- [#1156](#1156)
[`3a82f06`](3a82f06)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add
`cursor.remainingNodes()` API to allow iterating over all the remaining
nodes in the current tree, moving in pre-order traversal, until the tree
is completed.

- [#1223](#1223)
[`3e85a14`](3e85a14)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - split
`Parser.parse()` API into `parse_file_contents()` and
`parse_nonterminal()`.

- [#1194](#1194)
[`7a25d63`](7a25d63)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add a
`CompilationBuilder` API to incrementally load and resolve source files
and their imports.

- [#1223](#1223)
[`3e85a14`](3e85a14)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - rename
`Query.parse()` to `Query.create()`, and provide exact `TextRange` for
any errors it returns.

- [#1172](#1172)
[`6102886`](6102886)
Thanks [@beta-ziliani](https://github.com/beta-ziliani)! - Improved
error recovery, where leading trivia are always parsed and included
before an erroneous terminal.

- [#1223](#1223)
[`3e85a14`](3e85a14)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add
`TerminalKindExtensions.is_identifier()` API to distinguish terminals
like Solidity's `Identifier` and Yul's `YulIdentifier`.

### Patch Changes

- [#1134](#1134)
[`cfc62f2`](cfc62f2)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - remove
`YulPathComponent` and just use `YulIdentifier` instead.

- [#1138](#1138)
[`44a706f`](44a706f)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - add `ThisKeyword`
and `SuperKeyword` to the grammar, instead of parsing them as
identifiers.

- [#1134](#1134)
[`cfc62f2`](cfc62f2)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - unreserve
`AddressKeyword`, and let it be used for `MemberAccessExpression`,
`StructMember`, etc...

- [#1154](#1154)
[`7b9b478`](7b9b478)
Thanks [@beta-ziliani](https://github.com/beta-ziliani)! - Adding
support for deprecated keywords `jump` and `jumpi`

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants