immersed: add option to open firewall ports and libraries for hardware encoding support #399766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandapip1
reviewed
Apr 18, 2025
| @@ -25,6 +25,8 @@ appimageTools.wrapAppImage { | |||
|
|
|||
| extraPkgs = | |||
| pkgs: with pkgs; [ | |||
| libva | |||
| intel-media-driver | |||
There was a problem hiding this comment.
Might as well add all the other common VAAPI backends.
Suggested change
| intel-media-driver | |
| # VAAPI backends | |
| intel-media-driver | |
| intel-vaapi-driver | |
| nvidia-vaapi-driver | |
| mesa | |
| # Other dependencies |
See https://wiki.archlinux.org/title/Hardware_video_acceleration for a description of the various backends. I'm not quite confident that mesa will work to add AMD vaapi support, but we'll see.
There was a problem hiding this comment.
I haven't included the other backends as I miss the hardware to test whether their setup actually works, but we can indeed add them and wait for feedback by someone who can give them a try.
Pandapip1
approved these changes
Aug 13, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates Immersed NixOS Module and Package to:
libva,intel-media-driver,intel-vaapi-driver,nvidia-vaapi-driverandmesa)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.