-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
calamares: update to qt6 #399668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calamares: update to qt6 #399668
Conversation
I tried building the ISO with |
OK, the
I see some smaller problems:
I haven't checked if those problems were already there earlier, to me they don't feel like showstoppers for dropping qt5 tbh. This produced a system that I could boot into just fine with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot switch to an earlier phase using the menu on the left, only with the previous/next buttons
This is normal for us.
The 'overview' page at the end was too big for the size of the window, I had to manually maximize the window to be able to continue
This is, believe it or not, also normal for us :P
The step where I select whether to include LibreOffice, not include LibreOffice or perform a minimal install is in the 'Unfree Software' category, which seems odd.
That screen doesn't exist at all prior to this change. So calamares is doing something weird that we need to account for. This is in fact a showstopper because the buttons in this UI will not do anything, and we lose the ability to allow unfree software.
Thank you very much for having a look! OK, so it'd be good to zoom in on |
Ah, right, that doesn't make sense then
(fwiw I'd personally be OK with that being a manual step after installation, but I suppose that's my bias showing 😄) |
The QML in the |
calamares is the only remaining dependency on qt5.qtwebengine in the graphical installer
Fixed the |
Is there anything in particular that needs porting? I'm not very familiar with QML but I don't see anything particularly wrong? |
no longer needed since #430636 is in |
calamares is the only remaining dependency on qt5.qtwebengine in the graphical installer
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.