Skip to content

nosql-booster: 8.1.9 -> 10.0.0 #398820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

nosql-booster: 8.1.9 -> 10.0.0 #398820

wants to merge 0 commits into from

Conversation

guillaumematheron
Copy link
Contributor

Updated nosql-booster to 10.0.0

  • Increase compatibiltiy with mongoDB
  • AI helper

Tested and seems to work properly.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 15, 2025
Prince213
Prince213 suggested changes Apr 15, 2025
View reviewed changes
Prince213
Prince213 suggested changes Apr 15, 2025
View reviewed changes
Copy link
Member

@Prince213 Prince213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the two commits together.

Prince213
Prince213 approved these changes May 17, 2025
View reviewed changes
Copy link
Member

@Prince213 Prince213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package can build and launch on x86_64-linux.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 17, 2025
@guillaumematheron
Copy link
Contributor Author

Is there something more needed to get this PR merged ?

@nixpkgs-ci nixpkgs-ci bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Aug 8, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 15, 2025
Prince213
Prince213 suggested changes Aug 16, 2025
View reviewed changes
Copy link
Member

@Prince213 Prince213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the commit you wish to merge is to init the package at 8.1.9, not to upgrade the package to 10.0.0.

@Prince213 Prince213 removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 16, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 16, 2025
@guillaumematheron
Copy link
Contributor Author

Looks like the commit you wish to merge is to init the package at 8.1.9, not to upgrade the package to 10.0.0.

Ah yes sorry I should not have done a PR from my master branch. This should be fixed now

@Prince213
Copy link
Member

Please rebase you change on top of latest master so there's only one commit.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 19, 2025
@guillaumematheron
Copy link
Contributor Author

guillaumematheron commented Aug 19, 2025 •
edited
Loading

Not sure why this got closed, I suppose at one point my master matched origin/master. I believe we should be ok now, apologies for the confusing history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Prince213 Prince213 Prince213 requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaumematheron @Prince213 @wegank