lib/minver: bump to nix 2.18.0 #398444
Open
lib/minver: bump to nix 2.18.0 #398444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved sentence: **This version was released in September 2023**, which should provide **users with sufficient time to upgrade**. Bumping to this version allows us to use unsafeDiscardReferences for NixOS images. Additionally, the current minimum version (2.3.17) contains **several unpatched security vulnerabilities** as documented in the Nix security advisories. While not all vulnerabilities apply to version 2.3, maintaining an older version requirement would force us to run that same version for regression testing, which is problematic from a security perspective.
Mic92
commented
Apr 13, 2025
| @@ -1,2 +1,2 @@ | |||
| # Expose the minimum required version for evaluating Nixpkgs | |||
| "2.3.17" | |||
There was a problem hiding this comment.
Why does this version actually needs to be packaged in Nix? We should be just able to use a different version of Nix for our tarball check, no?
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved sentence:
This version was released in September 2023, which should provide users with sufficient time to upgrade.
Bumping to this version allows us to use unsafeDiscardReferences for NixOS images. Additionally, the current minimum version (2.3.17) contains several unpatched security vulnerabilities as documented in the Nix security advisories. While not all vulnerabilities apply to version 2.3, maintaining an older version requirement would force us to run that same version for regression testing, which is problematic from a security perspective.