Skip to content

apache-hop: init at 2.14.0 #397937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

apache-hop: init at 2.14.0 #397937

wants to merge 1 commit into from

Conversation

das-g
Copy link
Member

@das-g das-g commented Apr 11, 2025 •
edited
Loading

closes #390511

refined at the #ZurichZHF 25.05 event

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@das-g
Copy link
Member Author

das-g commented Apr 11, 2025

(This (e10e558) seems to work, but I'd like to enable at least the tests that we can get to pass.)

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 11, 2025
@das-g das-g force-pushed the apache-hop branch 3 times, most recently from e10e558 to 06eba4d Compare April 14, 2025 13:43
@das-g das-g force-pushed the apache-hop branch 6 times, most recently from ab91d46 to 9b4bb3c Compare May 25, 2025 13:06
@das-g das-g changed the title apache-hop: init at 2.12.0 apache-hop: init at 2.14.0 May 25, 2025
@das-g das-g marked this pull request as ready for review May 25, 2025 14:52
@Nebucatnetzer
Copy link
Contributor

Because of past experience I'm a fan of tests.
Even a simple version test already helps a lot IMO.

https://github.com/Nebucatnetzer/nixpkgs/blob/master/pkgs/by-name/dm/dmarc-report-converter/package.nix#L30

@das-g
Copy link
Member Author

das-g commented May 25, 2025

Because of past experience I'm a fan of tests.

Good point. I couldn't yet figure out how to disable only the failing tests.

Even a simple version test already helps a lot IMO.

https://github.com/Nebucatnetzer/nixpkgs/blob/master/pkgs/by-name/dm/dmarc-report-converter/package.nix#L30

Good idea! How would I do that here? This derivation provides the following executables:

name supports --version supports --help
hop-conf ✅¹ ✅¹
hop-encrypt ❌³ ❌³
hop-gui ❌² ❌²
hop-import ✅¹ ✅¹
hop-run ✅¹ ✅¹
hop-search ✅¹ ✅¹
hop-server ❌³ ❌³

¹ but exit code is 1
² launches the GUI no matter what options I pass
³ but outputs usage information when invoked with unexpected options

@Nebucatnetzer
Copy link
Contributor

Good question, I don't know if there are other applications that already solved this.
You could add tests for all the binaries that support it.
I don't know if you can have multiple version tests or if you then need to write them by hand.
In this PR I refactored from the manual test to the version tests: https://github.com/NixOS/nixpkgs/pull/351666/files

As for the GUI spawning. We had a similar thing with a QT application yesterday and there the solution was an environment variable. For Java it seems to be this flag -Djava.awt.headless=true but I haven't tested it.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/zurich-25-05-zhf-hackathon-report/64882/1

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 4, 2025
qzylinra
qzylinra reviewed Aug 16, 2025
View reviewed changes
qzylinra
qzylinra reviewed Aug 16, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 16, 2025
@das-g das-g requested a review from qzylinra August 16, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qzylinra qzylinra Awaiting requested review from qzylinra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: apache-hop
4 participants
@das-g @Nebucatnetzer @nixos-discourse @qzylinra