Skip to content

nixos/openvpn3: fix netcfg.systemd_resolved option #396940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nixos/openvpn3: fix netcfg.systemd_resolved option #396940

wants to merge 1 commit into from

Conversation

JarvisCraft
Copy link
Contributor

@JarvisCraft JarvisCraft commented Apr 7, 2025 •
edited
Loading

Things done

This should fix #385620

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 7, 2025
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@JarvisCraft JarvisCraft force-pushed the openvpn3-non-systemd-resolved branch from d9e535a to fec929f Compare April 7, 2025 23:27
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@JarvisCraft JarvisCraft marked this pull request as draft April 7, 2025 23:30
@JarvisCraft JarvisCraft force-pushed the openvpn3-non-systemd-resolved branch from fec929f to 31ff142 Compare April 7, 2025 23:33
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 7, 2025
@JarvisCraft JarvisCraft marked this pull request as ready for review April 7, 2025 23:36
@JarvisCraft
Copy link
Contributor Author

@ofborg build nixosTests.openvpn3

@JarvisCraft JarvisCraft force-pushed the openvpn3-non-systemd-resolved branch from 3d1d4c4 to d6982c0 Compare April 8, 2025 00:22
@JarvisCraft
Copy link
Contributor Author

@ofborg build nixosTests.openvpn3

CertainLach
CertainLach reviewed Apr 26, 2025
View reviewed changes
@JarvisCraft JarvisCraft force-pushed the openvpn3-non-systemd-resolved branch from d6982c0 to 70101eb Compare April 26, 2025 22:41
@JarvisCraft JarvisCraft requested a review from CertainLach April 26, 2025 22:42
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 25, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 2, 2025
@JarvisCraft JarvisCraft force-pushed the openvpn3-non-systemd-resolved branch from 9d8dd49 to 842ddad Compare August 6, 2025 16:37
@JarvisCraft JarvisCraft force-pushed the openvpn3-non-systemd-resolved branch from 842ddad to 07f502f Compare August 16, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CertainLach CertainLach Awaiting requested review from CertainLach

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos/programs/openvpn3: Setting to disable systemd-resolved doesn't work in 24.11
2 participants
@JarvisCraft @CertainLach