unofficial-homestuck-collection: init at 2.7.2 #395534
Conversation
3fdbb4b to
0150ad5
Compare
0150ad5 to
247adbf
Compare
There was a problem hiding this comment.
it fails to start with this error:
22:45:55.233 (ElectronMain) › Disabling hardware acceleration
22:45:55.241 (ElectronMain) › null
22:45:55.249 (ElectronMain) › TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
at validateString (internal/validators.js:112:11)
at Object.join (path.js:1039:7)
at getFlashPath (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:46949:24)
at Module.<anonymous> (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:46961:21)
at __webpack_require__ (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:26:30)
at Object.<anonymous> (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:17365:18)
at __webpack_require__ (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:26:30)
at /nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:138:18
at Object.<anonymous> (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:141:10)
at Module._compile (internal/modules/cjs/loader.js:967:30)
22:45:55.249 (ElectronMain) › Loading check failed, loading setup mode
22:45:55.255 (ElectronMain) › Deferring app version checks until initial configuration is complete.
22:45:55.256 (ElectronMain) › Loading archive
(node:947408) UnhandledPromiseRejectionWarning: Error: No reference to asset directory
at loadArchiveData (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:46879:24)
at Module.<anonymous> (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:47082:3)
at __webpack_require__ (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:26:30)
at Object.<anonymous> (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:17365:18)
at __webpack_require__ (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:26:30)
at /nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:138:18
at Object.<anonymous> (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:141:10)
at Module._compile (internal/modules/cjs/loader.js:967:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
at Module.load (internal/modules/cjs/loader.js:815:32)
(node:947408) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:947408) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
22:45:58.248 (ElectronMain) › Loading archive
22:45:58.251 (ElectronMain) › Error reloading archive Error: No reference to asset directory
at loadArchiveData (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:46879:24)
at IpcMainImpl.<anonymous> (/nix/store/98c77kpalkydzgipn8yshfdj0kk7v2g6-unofficial-homestuck-collection-2.5.7-extracted/resources/app.asar/background.js:47099:23)
at IpcMainImpl.emit (events.js:223:5)
at WebContents.<anonymous> (electron/js2c/browser_init.js:173:8274)
at WebContents.emit (events.js:223:5)
[947408:0404/224559.070771:FATAL:gpu_data_manager_impl_private.cc(439)] GPU process isn't usable. Goodbye.
247adbf to
c447259
Compare
|
The error your getting should be able to be fixed with |
c447259 to
39f39c5
Compare
|
I added a wrapProgram that now adds that argument and it should fix it. |
|
39f39c5 to
ac5807e
Compare
There was a problem hiding this comment.
I'm iffy about adding something we know to be outdated and vulnerable to the tree. I'd welcome other reviewers to weigh in on the possible solutions for this.
For now, I'd recommend waiting for the rewrite before adding this to Nixpkgs. This package can be maintained in a separate, third-party flake for those who absolutely need it right now.
|
Just for linking purposes: Closes #368721 |
ac5807e to
b193485
Compare
|
Took me fifteen years but I have got this building outside of an app image!!! |
|
I will also note that unlike the AppImage and what is specified in package.json, this is using the newer versions of nodejs and electron (not electron 9 and nodejs 12) Everything seems to work fine |
b193485 to
b4848bf
Compare
|
It is not using a very old electron version. I have this building with the latest version :) Also the builtin flash player is provided in the asset pack and not this package, regardless I have modified it to enable ruffle by default since nix does not always like loading pre compilled shared objects. |
|
Huh, how does that work? Chromium removed support for the Flash plugin years ago, and Electron followed suit. I remember checking a while ago and the collection used a many years old version of Electron. I don’t quite see how you could make the plugin work with a contemporary version. |
|
Yeah by default it builds with electron 9, but I injected the nixpkgs version into electron builder. And it also seems to work fine. There were a few minor things I had to change to allow it to work, but Ive been using it without issue. Edit: Yeah I never got the proper flash plugin working, it refuses to load. Which is also why I have it set to use ruffle by default. And it has worked great for me. |
|
Image of it working on my laptop, electron 35, ruffle for flash. No EOL electron, no outdated bad flash plugin. :) |
|
Okay, yeah, I totally missed the explicit A few additional thoughts:
|
pkgs/by-name/un/unofficial-homestuck-collection/0001-fix-source.patch
Outdated
Show resolved
Hide resolved
|
I don't know if phantomJS is needed at all. Maybe I can try to get it to think its there when its actually not, and see if it works... Gonna go try that right now |
5508a00 to
cce7ea2
Compare
|
Just updated the package.nix to have it electron call it without building electron into the binary. This removed most of the inputs such as |
10a661f to
c784e92
Compare
|
As per my previous comment, no we do not need The license has been changed to
PhantomJS its not needed it seems. I made its |
c784e92 to
79a67f7
Compare
79a67f7 to
2a9fb1c
Compare
2a9fb1c to
1b9d99f
Compare
1b9d99f to
05ca522
Compare
05ca522 to
bf6fdcb
Compare
bf6fdcb to
86512cc
Compare
|
Updated this pull request to version 2.7.2. Also discussed with Gio, the maintainer of the UHC, and he is fine with a ruffle only package as long as its mentioned in the package description. |
|
@emilazy will you be able to re-review this? Thanks |
Needed by #368721
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.