nixos/boot.kernelPatches: description update #392641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can we remove the big chunk of example as isn't [formatted correctly](https://search.nixos.org/options?channel=24.11&show=boot.kernelPatches&from=0&size=50&sort=relevance&type=packages&query=kernel+parameters) on the search page and we already show it as an example
|
It would be nice to move the description of the options into the example then. |
I agree, and it is already in the example which was also the reason why I removed it from the description, does everything with my PR look alright :D |
|
No it isn't? The example doesn't have a full description of all possible suboptions. |
added possible options as well as their description in the "description" section
So I'm not very good with kernelPatches option yet and don't know what options are available, so instead I improved the old description just formatted it in a better way, is that alright? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can we remove the big chunk of example as isn't formatted correctly on the search page and we already show it as an example
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.